Skip to content

Commit

Permalink
Update node.js version to the active LTS version 22.13.1 (#2141)
Browse files Browse the repository at this point in the history
You'll need at least 22.13 to build now. Previous version 18.17.1 was
nearing end of support.

---------

Co-authored-by: Dmitry Vasilevsky <[email protected]>
  • Loading branch information
DmitryVasilevsky and Dmitry Vasilevsky authored Feb 6, 2025
1 parent f8c794d commit 6f655eb
Show file tree
Hide file tree
Showing 8 changed files with 35 additions and 17 deletions.
16 changes: 16 additions & 0 deletions .ado/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ extends:
inputs:
versionSpec: '3.11'

- task: UseNode@1
inputs:
version: "20.x"

- script: |
python ./prereqs.py --install && python ./version.py
displayName: Install Prereqs and set version
Expand Down Expand Up @@ -155,6 +159,10 @@ extends:
inputs:
versionSpec: '3.11'

- task: UseNode@1
inputs:
version: "20.x"

- script: |
python ./prereqs.py --install && python ./version.py
displayName: Install Prereqs and set version
Expand Down Expand Up @@ -212,6 +220,10 @@ extends:
inputs:
versionSpec: '3.11'

- task: UseNode@1
inputs:
version: "20.x"

- script: |
python ./prereqs.py --skip-wasm && python ./version.py
displayName: Install Prereqs and set version
Expand Down Expand Up @@ -280,6 +292,10 @@ extends:
inputs:
versionSpec: '3.11'

- task: UseNode@1
inputs:
version: "20.x"

- script: |
python ./prereqs.py --skip-wasm && python ./version.py
displayName: Install Prereqs and set version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bench-reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

env:
CARGO_TERM_COLOR: always
NODE_VERSION: "18.17.1"
NODE_VERSION: "20.18.2"
PYTHON_VERSION: "3.11"
RUST_TOOLCHAIN_VERSION: "1.84"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ concurrency:

env:
CARGO_TERM_COLOR: always
NODE_VERSION: "18.17.1"
NODE_VERSION: "20.18.2"
PYTHON_VERSION: "3.11"
RUST_TOOLCHAIN_VERSION: "1.84"
RUST_TOOLCHAIN_COMPONENTS: rustfmt clippy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/memory_profile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:

env:
CARGO_TERM_COLOR: always
NODE_VERSION: "18.17.1"
NODE_VERSION: "20.18.2"
PYTHON_VERSION: "3.11"
RUST_TOOLCHAIN_VERSION: "1.84"
RUST_TOOLCHAIN_COMPONENTS: rustfmt clippy
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-playground.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
python-version: '3.11'
- uses: actions/setup-node@v3
with:
node-version: '18.17.1'
node-version: '20.18.2'
- uses: Swatinem/rust-cache@v2
- name: Prereqs
run: python ./prereqs.py --install
Expand Down
22 changes: 12 additions & 10 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
],
"license": "MIT",
"engines": {
"node": ">=18.17.1"
"node": ">=20.18.2"
},
"scripts": {
"eslint:check": "eslint -c ./eslint.config.mjs --max-warnings 0 ./",
Expand All @@ -24,7 +24,7 @@
"@types/chai": "^4.3.8",
"@types/markdown-it": "^14.1.1",
"@types/mocha": "^10.0.2",
"@types/node": "^18.17",
"@types/node": "^20.17",
"@types/vscode": "^1.83.0",
"@types/vscode-webview": "^1.57.3",
"@vscode/debugadapter": "^1.63.0",
Expand Down
2 changes: 1 addition & 1 deletion prereqs.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
python_ver = (3, 11) # Python support for Windows on ARM64 requires v3.11 or later
rust_ver = (1, 84) # Ensure Rust version 1.84 or later is installed
node_ver = (
20,
18,
17,
)
wasmpack_ver = (0, 12, 1) # Latest tested wasm-pack version
rust_fmt_ver = (1, 8, 0) # Current version when Rust 1.84 shipped
Expand Down

0 comments on commit 6f655eb

Please sign in to comment.