Skip to content

Commit

Permalink
Remove superfluous and flawed telemetry event (#821)
Browse files Browse the repository at this point in the history
Thanks @minestarks for pointing this out. This event only fires when
cells are set to q# for the first
time, not on subsequent cell accesses. This isn't particularly useful
telemetry. Additionally, this event
is superseded by [this
event](https://github.com/microsoft/qsharp/blob/main/vscode/src/extension.ts#L121).
  • Loading branch information
sezna authored Oct 30, 2023
1 parent 0a063b0 commit 0f64348
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
2 changes: 0 additions & 2 deletions vscode/src/notebook.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import * as vscode from "vscode";
import { qsharpLanguageId } from "./common.js";
import { EventType, sendTelemetryEvent } from "./telemetry.js";
import { WorkspaceTreeProvider } from "./azure/treeView.js";
import { getPythonCodeForWorkspace } from "./azure/workspaceActions.js";
import { notebookTemplate } from "./notebookTemplate.js";
Expand Down Expand Up @@ -58,7 +57,6 @@ export function registerQSharpNotebookHandlers() {
cell.document,
qsharpLanguageId,
);
sendTelemetryEvent(EventType.QSharpJupyterCellInitialized);
}
}
}
Expand Down
5 changes: 0 additions & 5 deletions vscode/src/telemetry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { log } from "qsharp-lang";
export enum EventType {
InitializePlugin = "Qsharp.InitializePlugin",
LoadLanguageService = "Qsharp.LoadLanguageService",
QSharpJupyterCellInitialized = "Qsharp.JupyterCellInitialized",
ReturnCompletionList = "Qsharp.ReturnCompletionList",
GenerateQirStart = "Qsharp.GenerateQirStart",
GenerateQirEnd = "Qsharp.GenerateQirEnd",
Expand Down Expand Up @@ -45,10 +44,6 @@ type EventTypes = {
timeToStartMs: number;
};
};
[EventType.QSharpJupyterCellInitialized]: {
properties: Empty;
measurements: Empty;
};
[EventType.ReturnCompletionList]: {
properties: Empty;
measurements: { timeToCompletionMs: number; completionListLength: number };
Expand Down

0 comments on commit 0f64348

Please sign in to comment.