Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VCR recording for simulator tests #3375

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ninghu
Copy link
Member

@ninghu ninghu commented Jun 4, 2024

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ninghu ninghu marked this pull request as ready for review June 4, 2024 18:27
@ninghu ninghu requested a review from a team as a code owner June 4, 2024 18:27
Copy link

github-actions bot commented Jun 4, 2024

promptflow-evals test result

  9 files  ±0    9 suites  ±0   1h 27m 6s ⏱️ - 4m 50s
 39 tests ±0   35 ✅ ±0   4 💤 ±0  0 ❌ ±0 
351 runs  ±0  315 ✅ ±0  36 💤 ±0  0 ❌ ±0 

Results for commit 456a413. ± Comparison against base commit 78d8ada.

♻️ This comment has been updated with latest results.

@ninghu ninghu merged commit dd7b7c9 into main Jun 4, 2024
35 checks passed
@ninghu ninghu deleted the users/ninhu/enable_vcr_for_simulator branch June 4, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants