-
Notifications
You must be signed in to change notification settings - Fork 957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[trace][devkit] Support new design of collection in trace experience #2747
Conversation
promptflow-tracing test result 12 files 12 suites 11s ⏱️ Results for commit 03ae26f. ♻️ This comment has been updated with latest results. |
promptflow SDK CLI Azure E2E Test Result zhengfei/feature/trace-collection 4 files 4 suites 4m 44s ⏱️ Results for commit 03ae26f. ♻️ This comment has been updated with latest results. |
Executor Unit Test Result zhengfei/feature/trace-collection778 tests 778 ✅ 3m 41s ⏱️ Results for commit 03ae26f. ♻️ This comment has been updated with latest results. |
Executor E2E Test Result zhengfei/feature/trace-collection238 tests 236 ✅ 8m 0s ⏱️ Results for commit 03ae26f. ♻️ This comment has been updated with latest results. |
SDK CLI Test Result zhengfei/feature/trace-collection 4 files 4 suites 44m 59s ⏱️ Results for commit 03ae26f. ♻️ This comment has been updated with latest results. |
Description
This PR targets to support new design of collection in trace.
SDK experience with
start_trace
collection
, we will honor it, until next time user specifiesCLI experience to specify collection
Support
pf flow test ... --collection <collection>
to specify collection, similar experience asstart_trace
in CLILocal to cloud experience
Update urls for portal trace ui, will distinguish Azure ML workspace and AI project, flow test and batch run.
Minor: new session id concept support
Will set
session_id
in span attributes now, which serves for chat-windows experience.Copilot-generated description
New Collection Parameter:
src/promptflow-devkit/promptflow/_cli/_pf/_flow.py
: Theadd_parser_test_flow
function now includes a newcollection
parameter. This parameter is also passed to the_test_flow_interactive
,_test_flow_standard
, and_test_flow_experiment
functions. [1] [2] [3] [4] [5]src/promptflow-devkit/promptflow/_sdk/_orchestrator/run_submitter.py
: The_run_bulk
function now importsis_collection_writeable
and uses it to determine whether to use the flow name as the collection.src/promptflow-devkit/promptflow/_sdk/_orchestrator/test_submitter.py
: Theinit
function now accepts acollection
parameter. This parameter is then used to determine whether to use the user-specified collection or the flow name as the collection. [1] [2] [3] [4]Refactoring and Logging Improvements:
src/promptflow-devkit/promptflow/_sdk/_tracing.py
: Several functions in this file have been refactored for better clarity and organization. Additionally, logging statements have been added or improved for better debugging. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines