Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trace][devkit] Support new design of collection in trace experience #2747

Merged
merged 25 commits into from
Apr 12, 2024

Conversation

zhengfeiwang
Copy link
Contributor

@zhengfeiwang zhengfeiwang commented Apr 11, 2024

Description

This PR targets to support new design of collection in trace.

SDK experience with start_trace

  • if user specifies collection, we will honor it, until next time user specifies
  • if not specify, will use current working directory
  • when not specify and flow test or batch run, will use flow path folder name

CLI experience to specify collection

Support pf flow test ... --collection <collection> to specify collection, similar experience as start_trace in CLI

Local to cloud experience

Update urls for portal trace ui, will distinguish Azure ML workspace and AI project, flow test and batch run.

Minor: new session id concept support

Will set session_id in span attributes now, which serves for chat-windows experience.

Copilot-generated description

New Collection Parameter:

Refactoring and Logging Improvements:

All Promptflow Contribution checklist:

  • The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link

github-actions bot commented Apr 11, 2024

promptflow-tracing test result

 12 files   12 suites   11s ⏱️
 55 tests  55 ✅ 0 💤 0 ❌
660 runs  660 ✅ 0 💤 0 ❌

Results for commit 03ae26f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

promptflow SDK CLI Azure E2E Test Result zhengfei/feature/trace-collection

  4 files    4 suites   4m 44s ⏱️
213 tests 193 ✅ 20 💤 0 ❌
852 runs  772 ✅ 80 💤 0 ❌

Results for commit 03ae26f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Executor Unit Test Result zhengfei/feature/trace-collection

778 tests   778 ✅  3m 41s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 03ae26f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

Executor E2E Test Result zhengfei/feature/trace-collection

238 tests   236 ✅  8m 0s ⏱️
  1 suites    2 💤
  1 files      0 ❌

Results for commit 03ae26f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 11, 2024

SDK CLI Test Result zhengfei/feature/trace-collection

    4 files      4 suites   44m 59s ⏱️
  579 tests   558 ✅ 21 💤 0 ❌
2 316 runs  2 232 ✅ 84 💤 0 ❌

Results for commit 03ae26f.

♻️ This comment has been updated with latest results.

0mza987
0mza987 previously approved these changes Apr 11, 2024
huaiyan
huaiyan previously approved these changes Apr 11, 2024
@wangchao1230 wangchao1230 merged commit 391f35e into main Apr 12, 2024
71 checks passed
@wangchao1230 wangchao1230 deleted the zhengfei/feature/trace-collection branch April 12, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants