Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redirect to docs/test-runners for non-existing port guides #1396

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented May 31, 2024

One idea was to hide the language from the drop-down if the page does not exist, Debbie instead prefers redirecting to /docs/intro so the user always is aware that we are compatible with 4 languages.

Closes microsoft/playwright#30890

Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1396.centralus.azurestaticapps.net

1 similar comment
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1396.centralus.azurestaticapps.net

@mxschmitt mxschmitt changed the title chore: hide language picker for non-existing port sites chore: redirect to docs/intro for non-existing port guides May 31, 2024
@mxschmitt mxschmitt force-pushed the hide-language-picker-for-404-pages branch 3 times, most recently from 2cc066e to a461c8c Compare May 31, 2024 13:42
Copy link
Member

@yury-s yury-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously it was clear that the page is not there in the port but now it looks like a broken redirect to me. It seems that for the bugs like the one from the report, we could help a bit by redirecting to a page with closest content, like to testing in .net rather than to always to intro. Otherwise I'd leave existing behavior.

@michael-freidgeim-webjet
Copy link

michael-freidgeim-webjet commented Jun 1, 2024

It seems that for the bugs like the one from the report, we could help a bit by redirecting to a page with closest content, like to testing in .net rather than to always to intro.

If there is a not the same but similar content, redirecting to a page with closest content, like to testing in .net rather than to always to intro will be appreciated.

Consider instead of automated redirects to have small stub pages with explicit links, e.g.

For .Net this topic is covered in section (link)

@mxschmitt mxschmitt changed the title chore: redirect to docs/intro for non-existing port guides chore: redirect to docs/test-runners for non-existing port guides Jun 2, 2024
@mxschmitt mxschmitt force-pushed the hide-language-picker-for-404-pages branch from e449888 to acbeb2f Compare June 3, 2024 14:54
Copy link
Contributor

github-actions bot commented Jun 3, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1396.centralus.azurestaticapps.net

@mxschmitt mxschmitt merged commit e4276df into main Jun 3, 2024
6 checks passed
@mxschmitt mxschmitt deleted the hide-language-picker-for-404-pages branch June 3, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: test-configuration For .Net
4 participants