feat(testing-harness): allow connecting remotely #3098
+278
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
reviewed
Jan 24, 2025
mxschmitt
force-pushed
the
feat/allow-connecting-remote
branch
2 times, most recently
from
d9e68ba to
9f889d6
Compare
kblok
reviewed
Jan 28, 2025
| @@ -41,27 +42,48 @@ private BrowserService(IBrowser browser) | |||
| Browser = browser; | |||
| } | |||
|
|
|||
| public static Task<BrowserService> Register(WorkerAwareTest test, IBrowserType browserType) | |||
| public static Task<BrowserService> Register(WorkerAwareTest test, IBrowserType browserType, PlaywrightConnectOptions? connectOptions) | |||
There was a problem hiding this comment.
I see that this class is not using the Async suffix. Was this on purpose or a mistake?
Sid200026
approved these changes
Jan 30, 2025
dgozman
approved these changes
Jan 30, 2025
mxschmitt
force-pushed
the
feat/allow-connecting-remote
branch
from
84193c0 to
86fea44
Compare
mxschmitt
force-pushed
the
feat/allow-connecting-remote
branch
from
86fea44 to
c591630
Compare
mxschmitt
force-pushed
the
feat/allow-connecting-remote
branch
from
c591630 to
59b18e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnlyNUnitfor now until the API design has been clarified.