chore: add additional net8.0 TFM

src/Playwright.Examples/Playwright.Examples.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
@@ -9,6 +9,10 @@
     <NoWarn>CA2007</NoWarn>
     <ReleaseVersion>0.0.0</ReleaseVersion>
   </PropertyGroup>
+  <PropertyGroup>
+    <PublishAot>true</PublishAot>
+  </PropertyGroup>
+
 
   <!-- Required since we're not actually referencing Playwright -->
   <Import Project="../Playwright.Tests/build/Playwright.Tests.targets" />

src/Playwright/Helpers/JsonExtensions.cs

@@ -26,6 +26,9 @@
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using Microsoft.Playwright.Transport.Converters;
+#if NET8_0_OR_GREATER
+using System.Text.Json.Serialization.Metadata;
+#endif
 
 namespace Microsoft.Playwright.Helpers;
 
@@ -98,6 +101,9 @@ internal static JsonSerializerOptions GetNewDefaultSerializerOptions(bool keepNu
                     new JsonStringEnumMemberConverter(),
             },
         };
+#if NET8_0_OR_GREATER
+        options.TypeInfoResolver = new DefaultJsonTypeInfoResolver();
+#endif
         if (!keepNulls)
         {
             options.DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingNull;

src/Playwright/Playwright.csproj

@@ -7,7 +7,7 @@
     <Summary>The .NET port of Playwright, used to automate Chromium, Firefox and WebKit with a single API.</Summary>
     <Description>Playwright enables reliable end-to-end testing for modern web apps. It is built to enable cross-browser web automation that is ever-green, capable, reliable and fast. Learn more at https://playwright.dev/dotnet/.</Description>
     <PackageIcon>icon.png</PackageIcon>
-    <TargetFramework>netstandard2.0</TargetFramework>
+    <TargetFrameworks>netstandard2.0;net8.0</TargetFrameworks>
     <PublishRepositoryUrl>true</PublishRepositoryUrl>
     <DocumentationFile>Microsoft.Playwright.xml</DocumentationFile>
     <RunWithWarnings>true</RunWithWarnings>
@@ -17,7 +17,7 @@
     <ReleaseVersion>0.0.0</ReleaseVersion>
     <BuildFromSource>True</BuildFromSource>
     <AnalysisMode>AllEnabledByDefault</AnalysisMode>
-    <NoWarn>1701;1702;CS0067;1734;NU5110;NU5111</NoWarn>
+    <NoWarn>1701;1702;CS0067;1734;NU5110;NU5111;CA1849;CA1861;CA1867;VSTHRD103;CA1510;CA1851;CA1835;CA2000</NoWarn>
     <AssemblyName>Microsoft.Playwright</AssemblyName>
     <NoWin32Manifest>true</NoWin32Manifest>
   </PropertyGroup>

src/Playwright/Transport/Connection.cs

@@ -32,6 +32,9 @@
 using System.Runtime.CompilerServices;
 using System.Text;
 using System.Text.Json;
+#if NET8_0_OR_GREATER
+using System.Text.Json.Serialization.Metadata;
+#endif
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.Playwright.Core;
@@ -59,7 +62,10 @@ public Connection(LocalUtils localUtils = null)
         JsonSerializerOptions NewJsonSerializerOptions(bool keepNulls)
         {
             var options = JsonExtensions.GetNewDefaultSerializerOptions(keepNulls);
-
+#if NET8_0_OR_GREATER
+            Console.WriteLine("Using reflection: JsonSerializer.IsReflectionEnabledByDefault: " + JsonSerializer.IsReflectionEnabledByDefault);
+            options.TypeInfoResolver = new DefaultJsonTypeInfoResolver();
+#endif
             // Workaround for https://github.com/dotnet/runtime/issues/46522
             options.Converters.Add(new ChannelOwnerConverterFactory(this));
             // Workaround for https://github.com/dotnet/runtime/issues/46522
@@ -312,6 +318,7 @@ internal void Dispatch(PlaywrightServerMessage message)
         }
     }
 
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Reliability", "CA2000:Dispose objects before losing scope", Justification = "We dispose manually inside the protocol")]
     private ChannelOwner CreateRemoteObject(string parentGuid, ChannelOwnerType type, string guid, JsonElement? initializer)
     {
         ChannelOwner result = null;

src/Playwright/Transport/Converters/EvaluateArgumentValueConverter.cs

@@ -376,6 +376,7 @@ private static object ParseEvaluateResultToExpando(JsonElement result, IDictiona
         return null;
     }
 
+#pragma warning disable SYSLIB0050 // Type or member is obsolete
     internal class VisitorInfo
     {
         internal VisitorInfo()
@@ -393,4 +394,5 @@ internal VisitorInfo()
         internal long Identity(object obj)
             => IDGenerator.GetId(obj, out _);
     }
+#pragma warning restore SYSLIB0050 // Type or member is obsolete
 }

src/Playwright/Transport/StdIOTransport.cs

@@ -178,7 +178,7 @@ private static void StartProcessWithUTF8IOEncoding(Process process)
         }
     }
 
-    private static Task ScheduleTransportTaskAsync(Func<CancellationToken, Task> func, CancellationToken cancellationToken)
+    private static Task<Task> ScheduleTransportTaskAsync(Func<CancellationToken, Task> func, CancellationToken cancellationToken)
         => Task.Factory.StartNew(() => func(cancellationToken), cancellationToken, TaskCreationOptions.LongRunning, TaskScheduler.Current);
 
     private void Dispose(bool disposing)