Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add install script for netevetebpfext and ntosebpfext #108

Merged
merged 3 commits into from
Sep 6, 2024
Merged

add install script for netevetebpfext and ntosebpfext #108

merged 3 commits into from
Sep 6, 2024

Conversation

LakshK98
Copy link
Contributor

@LakshK98 LakshK98 commented Sep 3, 2024 •
edited
Loading

Description

  1. Added install script for neteventebpfext and ntosebpfext.
  2. Added necessary netevetebpfext/ntosebpfext files to nuget package.

Testing

CI/CD ran successfully

Documentation

N/A

Installation

N/A

@LakshK98 LakshK98 force-pushed the neteventebpfext_nuget branch from 595f5c0 to ec24c6f Compare September 3, 2024 22:03
@LakshK98
Copy link
Contributor Author

LakshK98 commented Sep 4, 2024

@microsoft-github-policy-service agree company="Microsoft"

@LakshK98 LakshK98 changed the title add install script for netevetebpfext add install script for netevetebpfext and ntosebpfext Sep 4, 2024
@LakshK98 LakshK98 force-pushed the neteventebpfext_nuget branch from 0730738 to 7634cdf Compare September 5, 2024 21:19
@LakshK98 LakshK98 force-pushed the neteventebpfext_nuget branch from 7634cdf to 63938bf Compare September 5, 2024 22:26
@LakshK98 LakshK98 force-pushed the neteventebpfext_nuget branch from 63938bf to 6b96a5d Compare September 5, 2024 22:28
shpalani
shpalani reviewed Sep 6, 2024
View reviewed changes
Copy link
Contributor

@shpalani shpalani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LakshK98 : How was this installation script tested? Any manual logs showing "Installation Complete!"?

@LakshK98
Copy link
Contributor Author

LakshK98 commented Sep 6, 2024

@LakshK98 : How was this installation script tested? Any manual logs showing "Installation Complete!"?

For the nuget package changes, the package created and uploaded in "CI/CD/regular/build(Release)" has the files I added.
For the install script, I tested it locally with all combinations of Action=Install/Uninstall and Extension=neteventebpfext/ntosebpfext

@shpalani shpalani self-requested a review September 6, 2024 16:31
@shpalani shpalani merged commit 4918ca8 into microsoft:main Sep 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeagun mikeagun mikeagun approved these changes

@matthewige matthewige matthewige approved these changes

@shpalani shpalani shpalani approved these changes

@poornagmsft poornagmsft Awaiting requested review from poornagmsft poornagmsft is a code owner

@Alan-Jowett Alan-Jowett Awaiting requested review from Alan-Jowett Alan-Jowett is a code owner

@saxena-anurag saxena-anurag Awaiting requested review from saxena-anurag saxena-anurag is a code owner

@shankarseal shankarseal Awaiting requested review from shankarseal shankarseal is a code owner

@dv-msft dv-msft Awaiting requested review from dv-msft dv-msft is a code owner

@gtrevi gtrevi Awaiting requested review from gtrevi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LakshK98 @mikeagun @matthewige @shpalani