Remove Static JAAS Configuration Setting in KerbAuthentication #2590
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2590 +/- ##
============================================
+ Coverage 51.22% 51.34% +0.11%
- Complexity 3956 3977 +21
============================================
Files 147 147
Lines 33657 33655 -2
Branches 5624 5624
============================================
+ Hits 17241 17280 +39
+ Misses 14002 13980 -22
+ Partials 2414 2395 -19 ☔ View full report in Codecov by Sentry. |
muskan124947
changed the title
muskan124947
requested review from
lilgreenbird,
divang,
Jeffery-Wasty,
David-Engel,
Ananya2,
tkyc,
machavan and
codewatchzen
|
@muskan124947 Please include a detailed description of the change (what, why, behavior implications, etc.) and link to the source issue (if applicable) so that we can have context for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #2586 -> Driver should not override default JAAS configuration
Action: Remover call javax.security.auth.login.Configuration.setConfiguration from static block in class com.microsoft.sqlserver.jdbc.KerbAuthentication