Stored procedure call returns wrong BigDecimal scale and integrated Mockito Dependency into JDBC Driver Codebase. #2582
+194
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machavan
previously approved these changes
Jan 16, 2025
|
/azp run public-mssql-jdbc.windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run public-mssql-jdbc.linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run CI-MacOS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2582 +/- ##
============================================
+ Coverage 51.35% 51.37% +0.01%
- Complexity 3972 3975 +3
============================================
Files 147 147
Lines 33664 33672 +8
Branches 5626 5627 +1
============================================
+ Hits 17288 17298 +10
+ Misses 13939 13937 -2
Partials 2437 2437 ☔ View full report in Codecov by Sentry. |
David-Engel
reviewed
Jan 23, 2025
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java
Outdated
Show resolved
Hide resolved
…est case to validate registerOutParameter method catch block for BigDecimal.
… higher versions.
Ananya2
changed the title
Ananya2
requested review from
David-Engel,
machavan,
codewatchzen,
lilgreenbird,
divang and
Jeffery-Wasty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2534 - Set scale value dynamically for DECIMAL output parameters in registerOutParameter method.
This change retrieves the scale from the ParameterMetaData and applies it to the DECIMAL output parameter. This provides a more flexible approach for handling DECIMAL data types.
As an alternative, users can directly call registerOutParameter(index, sqlType, scale) to specify the scale explicitly.
And integrated Mockito Dependency into JDBC Driver Codebase. https://sqlclientdrivers.visualstudio.com/mssql-jdbc/_workitems/edit/33295