IBM Semeru Runtime Certified Edition for z/OS, Kerberos and mssql-jdbc don't work together #2576

[muskan124947]

Github Issue: #2576

[muskan124947]

/azp run public-mssql-jdbc.windows

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[muskan124947]

/azp run public-mssql-jdbc.linux

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[muskan124947]

/azp run CI-MacOS

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[codecov]

Codecov Report

Attention: Patch coverage is 21.42857% with 22 lines in your changes missing coverage. Please review.

Project coverage is 51.22%. Comparing base (03cfcfd) to head (6187602).

Files with missing lines	Patch %	Lines
...om/microsoft/sqlserver/jdbc/JaasConfiguration.java	0.00%	12 Missing ⚠️
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java	50.00%	5 Missing and 1 partial ⚠️
...m/microsoft/sqlserver/jdbc/KerbAuthentication.java	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2581   +/-   ##
=========================================
  Coverage     51.22%   51.22%           
- Complexity     3956     3957    +1     
=========================================
  Files           147      147           
  Lines         33657    33678   +21     
  Branches       5624     5624           
=========================================
+ Hits          17241    17252   +11     
- Misses        14002    14011    +9     
- Partials       2414     2415    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[machavan]

Please run

• azp run
  -ADO tests with this branch

[muskan124947]

/azp run public-mssql-jdbc.linux

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[muskan124947]

tested with ado pipeline
https://sqlclientdrivers.visualstudio.com/mssql-jdbc/_build/results?buildId=105806&view=results

[lilgreenbird]

we only need to do this if isIBM(). Would it be better to just add this in Util.isIBM()?

[machavan]

@lilgreenbird The issue was reported due to a problem with Util.isIBM method implementation ( #2139)

Do you mean just adding the try catch logic in Util.isIBM method to improve it and leaving everything else unchanged?

So something like this ?

    private static Boolean isIBM = null;
    static boolean isIBM() {
        if (isIBM != null) {
            return isIBM;
        }

        String vmName = System.getProperty("java.vm.name");
        if (SYSTEM_JRE.startsWith("IBM") && vmName.startsWith("IBM")) {
            isIBM = true;
            return isIBM;
        } 

        try {
            Class.forName("com.ibm.security.auth.module.Krb5LoginModule");
            isIBM = true;
        } catch (ClassNotFoundException ex) {
            isIBM = false;
        }
        return isIBM;
    }

[lilgreenbird]

yes that's what I meant :)

[lilgreenbird]

codecov error, need a test case for this