Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken mssql-jdbc.properties location logic #2579

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+23 −4

Fixed according to code review

f902c81
Select commit
Loading
Failed to load commit list.
Open

Fix for broken mssql-jdbc.properties location logic #2579

Fixed according to code review
f902c81
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 1s

51.37% (+0.36%) compared to 5bb3353

View this Pull Request on Codecov

51.37% (+0.36%) compared to 5bb3353

Details

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.37%. Comparing base (5bb3353) to head (f902c81).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...crosoft/sqlserver/jdbc/ConfigurableRetryLogic.java 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2579      +/-   ##
============================================
+ Coverage     51.01%   51.37%   +0.36%     
- Complexity     3921     3973      +52     
============================================
  Files           147      147              
  Lines         33483    33671     +188     
  Branches       5609     5628      +19     
============================================
+ Hits          17081    17299     +218     
+ Misses        13991    13935      -56     
- Partials       2411     2437      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov