-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#2550 - Fixed getGeneratedKeys functionality for execute API #2554
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
============================================
+ Coverage 51.22% 51.37% +0.14%
- Complexity 3953 3976 +23
============================================
Files 147 147
Lines 33657 33664 +7
Branches 5624 5626 +2
============================================
+ Hits 17241 17295 +54
+ Misses 13999 13936 -63
- Partials 2417 2433 +16 ☔ View full report in Codecov by Sentry. |
Internal tests pass |
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerStatement.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/StatementTest.java
Outdated
Show resolved
Hide resolved
…ev/machavan/issue#2550
Suggestion: may also wish to verify that the execute API works with |
Yes, verified with execute API and added a new test case |
ADO pipeline tests passed with the PR. |
Description:
The execute API for INSERT was not reading off the explicit TDS_DONE token that actually contains the update count returned by the server. As a result, it was not able to correctly report back the update count for getUpdateCount and also the subsequent resultsets on getMoreResults.
Note that this works correctly for excecuteUpdate API.
Testing: