IBM Semeru Runtime Certified Edition for z/OS, Kerberos and mssql-jdbc don't work together #2576 #2581
Conversation
…c don't work together #2576
|
/azp run public-mssql-jdbc.windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run public-mssql-jdbc.linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run CI-MacOS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2581 +/- ##
=========================================
Coverage 51.22% 51.22%
- Complexity 3956 3957 +1
=========================================
Files 147 147
Lines 33657 33678 +21
Branches 5624 5624
=========================================
+ Hits 17241 17252 +11
- Misses 14002 14011 +9
- Partials 2414 2415 +1 ☔ View full report in Codecov by Sentry. |
|
/azp run public-mssql-jdbc.linux |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
tested with ado pipeline |
muskan124947
requested review from
lilgreenbird,
Jeffery-Wasty,
tkyc and
codewatchzen
src/main/java/com/microsoft/sqlserver/jdbc/JaasConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/KerbAuthentication.java
Outdated
Show resolved
Hide resolved
|
|
||
| private static AppConfigurationEntry[] generateDefaultConfiguration() throws SQLServerException { | ||
| try { | ||
| if (useIbmModule) { |
There was a problem hiding this comment.
we only need to do this if isIBM(). Would it be better to just add this in Util.isIBM()?
There was a problem hiding this comment.
@lilgreenbird The issue was reported due to a problem with Util.isIBM method implementation ( #2139)
Do you mean just adding the try catch logic in Util.isIBM method to improve it and leaving everything else unchanged?
So something like this ?
private static Boolean isIBM = null;
static boolean isIBM() {
if (isIBM != null) {
return isIBM;
}
String vmName = System.getProperty("java.vm.name");
if (SYSTEM_JRE.startsWith("IBM") && vmName.startsWith("IBM")) {
isIBM = true;
return isIBM;
}
try {
Class.forName("com.ibm.security.auth.module.Krb5LoginModule");
isIBM = true;
} catch (ClassNotFoundException ex) {
isIBM = false;
}
return isIBM;
}
There was a problem hiding this comment.
yes that's what I meant :)
| */ | ||
| JaasConfiguration(Configuration delegate) { | ||
| JaasConfiguration(Configuration delegate) throws SQLServerException { |
There was a problem hiding this comment.
codecov error, need a test case for this
Github Issue: #2576