fix(monosize): resolve default argument resolution bug within collectLocalReport #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
changed the title
Hotell
commented
May 17, 2024
| @@ -65,7 +65,7 @@ describe('collectLocalReport', () => { | |||
| await fs.promises.writeFile(reportAPath, JSON.stringify(reportA)); | |||
| await fs.promises.writeFile(reportBPath, JSON.stringify(reportB)); | |||
|
|
|||
| expect(await collectLocalReport({ root: rootDir })).toMatchInlineSnapshot(` | |||
| expect(await collectLocalReport({ root: rootDir, reportFilesGlob: undefined })).toMatchInlineSnapshot(` | |||
There was a problem hiding this comment.
added explicit undefined to properly test if that args is not specified from CLI
layershifter
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.6 is failing when invoking
compare-reportshttps://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=343142&view=logs&j=f5e89eef-ad59-58c9-614d-c2fd6081e79d&t=a54a6299-9770-5aec-0235-c3967042cdfdFixes regression introduced #68