Update to Network Channel count calculation in test case 'verify_vmbus_devices_channels' #3644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiliDeng
reviewed
Feb 14, 2025
|
|
||
| # 2.1 Get expected channel count of each netvsc is min (num of vcpu, 8). | ||
| expected_network_channel_count = ( | ||
| node.tools[Ethtool].get_device_channels_info("eth0", True) |
There was a problem hiding this comment.
it is possible that case will change the combined channel count
There was a problem hiding this comment.
I think it is the actual value, not the expected value.
There was a problem hiding this comment.
I think it is the actual value, not the expected value.
Agree, the value should be calculated, instead of getting from the system. This test case is to verify if the count of channel is the same as designed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the network channel count calculation in the test case 'verify_vmbus_devices_channels' is based on the number of vCPUs and has a cap value of 8 - which might get updated, like in the following patch: [PATCH v4] net: netvsc: Update default VMBus channels
This patch is currently available in Upstream but not all downstream distros. Hence it is better to get the expected count using ethtool which would be dependent on the files updated in the patch above and help avoid discrepancies while testing different scenarios.