genpolicy: improved ExecProcessRequest input validation #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log into Pod VM's /tmp/policy.txt the policy print output for requests that get evaluated to false - to help debugging. This output was already provided for interactive commands - e.g., when ExecProcessRequest gets rejected for "kubectl exec". However, for non interactive requests - e.g., ExecProcessRequest for a livenessProbe - it can be helpful to set AllowRequestsFailingPolicy = true and to collect the policy prints from the Pod VM log file. Signed-off-by: Dan Mihai <[email protected]>
Using process data inputs for allow_process() is easier to read/understand compared with the older OCI data inputs. Signed-off-by: Dan Mihai <[email protected]>
Reuse constants where applicable Signed-off-by: Saul Paredes <[email protected]>
Validate more process fields for commands enabled using the ExecProcessRequest "commands" and/or "regex" fields from the settings file. Signed-off-by: Dan Mihai <[email protected]>
Validate more process fields for k8s probe commands - e.g., livenessProbe, readinessProbe, etc. Signed-off-by: Dan Mihai <[email protected]>
danmihai1
force-pushed
the
danmihai1/exec5
branch
from
37a4fd9 to
b20fa42
Compare
Add comment for missing ExecProcessRequest validation of container_id. Signed-off-by: Dan Mihai <[email protected]>
danmihai1
force-pushed
the
danmihai1/exec5
branch
from
b20fa42 to
79fc221
Compare
Redent0r
approved these changes
Dec 18, 2024
Update samples with the latest policy. Signed-off-by: Dan Mihai <[email protected]>
Redent0r
force-pushed
the
danmihai1/exec5
branch
from
79fc221 to
23fa27b
Compare
|
Changes were included in #278 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate additional ExecProcessRequest process fields.