genpolicy: block self paths for copyFile requests #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redent0r
force-pushed
the
saulparedes/block_self_directory_path
branch
2 times, most recently
from
792a59b to
aabde30
Compare
Self symlink paths are not useful and may cause security issues. Also move parent directory check to check_symlink_source since we only need this check for symlinks. We already filter self and parent input.path references in this regexp https://github.com/microsoft/kata-containers/blob/06ea44595d084461340fe172ec59826c168763ff/src/tools/genpolicy/rules.rego#L1185 Signed-off-by: Saul Paredes <[email protected]>
Redent0r
force-pushed
the
saulparedes/block_self_directory_path
branch
from
aabde30 to
eac886e
Compare
danmihai1
approved these changes
Dec 13, 2024
Update samples policy annotations Signed-off-by: Saul Paredes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
Self paths are not useful and may cause security issues
Test Methodology
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=695294&view=results [pass]