agent: fix make test #266
Merged
agent: fix make test #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sumynwa
added
the
upstream/not-needed
Sumynwa
force-pushed
the
sumsharma/pr_agent_make
branch
from
defa3b9 to
2ec1e51
Compare
|
@Sumynwa In your commit message please include both the WHAT and the WHY, and any context that can help understand this change - pretty vital when sorting through old commits 🙂 |
This commit fixes failing tests of test_get_device_name() & test_virtio_blk_matcher() by correctly constructing VirtioBlkPciMatcher. Commit c905577 for hotplugging block devices on PCI segments >= 1 modified VirtioBlkPciMatcher::new() to take the complete pci sysfs path instead of only the relative path. Signed-off-by: Sumedh Alok Sharma <[email protected]>
Sumynwa
force-pushed
the
sumsharma/pr_agent_make
branch
from
2ec1e51 to
e8c73d9
Compare
|
can we also fix the |
I will raise that in a separate PR. Thanks @arc9693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
This commit fixes failing tests
The changes correctly constructs VirtioBlkPciMatcher.
Commit c905577 for hotplugging block devices on PCI segments >= 1 modified VirtioBlkPciMatcher::new() to take the complete pci sysfs
path instead of only the relative path.
Test Methodology