samples: replicate nginx image to private ACR #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcr.microsoft.com/azurelinux/base/nginx:1 got updated again on 12/6 and caused test failures on our pipeline due to the policy annotation of images that depend on nginx getting outdated. Replicate this image to our private test images ACR so that is stable and doesn't get unknowingly updated or deleted. We will still test mcr.microsoft.com/azurelinux/base/nginx:1 under "common_images" category and detect any future possible image breaking changes. The result of this change will be more stable test results without loosing coverage. Signed-off-by: Saul Paredes <[email protected]>
Redent0r
added
the
upstream/not-needed
danmihai1
approved these changes
Dec 9, 2024
ms-mahuber
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
mcr.microsoft.com/azurelinux/base/nginx:1 got updated again on 12/6 and caused test failures on our pipeline due to the policy annotation of images that depend on nginx getting outdated.
Replicate this image to our private test images ACR so that is stable and doesn't get unknowingly updated or deleted. We will still test mcr.microsoft.com/azurelinux/base/nginx:1 under "common_images" category (https://github.com/microsoft/kata-containers/blob/msft-main/src/tools/genpolicy/policy_samples.json#L79) and detect any future possible image breaking changes.
The result of this change will be more stable test results without loosing test coverage.
Test Methodology
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=691499&view=results