Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install libdevmapper for agent static checks #258

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Sumynwa
Copy link

@Sumynwa Sumynwa commented Dec 2, 2024

Install libdevmapper for agent make test check.

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

Install device mapper for agent static build checks for both make check & make test.
This fixes the libdevicemapper.h not found when compiling devicemapper-sys crate.

Test Methodology

Install libdevmapper for agent make test check.

Signed-off-by: Sumedh Alok Sharma <[email protected]>
@Sumynwa Sumynwa requested review from a team as code owners December 2, 2024 18:39
@ms-mahuber
Copy link

Seems like we are using old code compared to upstream. This change addresses an issue in our older code base. Approving

@Sumynwa Sumynwa merged commit 33d2030 into msft-main Dec 3, 2024
45 of 56 checks passed
@Sumynwa Sumynwa deleted the sumsharma/fix_agent_build_checks branch December 3, 2024 05:42
sprt pushed a commit that referenced this pull request Feb 10, 2025
ci: install libdevmapper for agent static checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants