Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-builder: Deploy-only recipe for AzL3 VMs #254

Merged
merged 1 commit into from
Dec 3, 2024
Merged

node-builder: Deploy-only recipe for AzL3 VMs #254

merged 1 commit into from
Dec 3, 2024

Conversation

ms-mahuber
Copy link

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary
  • split deployment sections in node-builder README.md: With AzL3 being rolled out, we can simplify deployment based on bits on packages.microsoft.com without entire build from scratch. Further, build from scratch for AzL3 in Azure VMs is simplified as well. Hence, splitting into different build variants.
  • install jq, curl dependencies within IGVM script to streamline steps in README.md
  • add path parameter to UVM install script to be able to change README.md to use "make uvm deploy" commands instead of directly calling cp on the build artifacts
Test Methodology
  • manual build and deploy

@ms-mahuber ms-mahuber added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Nov 25, 2024
@ms-mahuber ms-mahuber changed the title node-builder: Deploy-only for AzL3 VMs node-builder: Deploy-only recipe for AzL3 VMs Nov 25, 2024
@ms-mahuber ms-mahuber marked this pull request as ready for review November 25, 2024 13:07
@ms-mahuber ms-mahuber requested review from a team as code owners November 25, 2024 13:07
@ms-mahuber ms-mahuber force-pushed the mahuber/build-readme-split branch from dea131b to 1210eac Compare November 26, 2024 09:27
@ms-mahuber
node-builder: Deploy-only for AzL3 VMs
eef2029 
- split deployment sections in node-builder README.md
- install jq, curl dependencies within IGVM script
- add path parameter to UVM install script

Signed-off-by: Manuel Huber <[email protected]>
@ms-mahuber ms-mahuber force-pushed the mahuber/build-readme-split branch from 1210eac to eef2029 Compare December 2, 2024 23:13
@ms-mahuber ms-mahuber merged commit f76a06a into msft-main Dec 3, 2024
43 of 54 checks passed
@ms-mahuber ms-mahuber deleted the mahuber/build-readme-split branch December 27, 2024 23:55
sprt pushed a commit that referenced this pull request Feb 10, 2025
@ms-mahuber @sprt
Merge pull request #254 from microsoft/mahuber/build-readme-split
1e81939 
node-builder: Deploy-only recipe for AzL3 VMs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmihai1 danmihai1 danmihai1 approved these changes

Assignees
No one assigned
Labels
upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-mahuber @danmihai1