Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump google.golang.org/protobuf from 1.29.1 to 1.33.0 in /src/runtime #243

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Oct 18, 2024

Bumps google.golang.org/protobuf from 1.29.1 to 1.33.0.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested review from a team as code owners October 18, 2024 14:16
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 18, 2024
@arc9693
Copy link

arc9693 commented Oct 18, 2024

Fixes CVE-2024-24786

@arc9693 arc9693 added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Oct 21, 2024
@ms-mahuber
Copy link

Please hold on with merging for now.

@Sumynwa
Copy link

Sumynwa commented Dec 2, 2024

PR Check is failing: https://github.com/microsoft/kata-containers/actions/runs/11405418793/job/31736857884?pr=243
The build is failing with protobuf bump witl below errors:

INFO: Running 'go test' as current user on package './...' with flags '-timeout 30s -race'
google.golang.org/protobuf/reflect/protoreflect
vendor/google.golang.org/protobuf/reflect/protoreflect/value_union.go:70:12: undefined: value
vendor/google.golang.org/protobuf/reflect/protoreflect/value_union.go:402:13: undefined: value
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:48:7: undefined: nilType
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:50:7: undefined: boolType
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:52:7: undefined: int32Type
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:52:18: undefined: int64Type
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:54:7: undefined: uint32Type
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:54:19: undefined: uint64Type
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:56:7: undefined: float32Type
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:56:20: undefined: float64Type
vendor/google.golang.org/protobuf/reflect/protoreflect/value_equal.go:56:20: too many errors

@Sumynwa
Copy link

Sumynwa commented Dec 2, 2024

This is happening because of our .gitignore ignoring vendor directories. So, when bumping protobuf version, the already added files were tracked for modifications/deletions.
The bump to 1.33.0 is incomplete, below additions are needed:

vendor/google.golang.org/protobuf/internal/editiondefaults/
vendor/google.golang.org/protobuf/internal/filedesc/editions.go
vendor/google.golang.org/protobuf/internal/genid/go_features_gen.go
vendor/google.golang.org/protobuf/internal/strs/strings_unsafe_go120.go
vendor/google.golang.org/protobuf/internal/strs/strings_unsafe_go121.go
vendor/google.golang.org/protobuf/reflect/protodesc/editions.go
vendor/google.golang.org/protobuf/reflect/protoreflect/value_unsafe_go120.go
vendor/google.golang.org/protobuf/reflect/protoreflect/value_unsafe_go121.go
vendor/google.golang.org/protobuf/types/gofeaturespb/

@Sumynwa
Copy link

Sumynwa commented Dec 5, 2024

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/src/runtime/google.golang.org/protobuf-1.33.0 branch from b3bb487 to 87f7b61 Compare December 5, 2024 06:17
Bumps google.golang.org/protobuf from 1.29.1 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@Sumynwa Sumynwa force-pushed the dependabot/go_modules/src/runtime/google.golang.org/protobuf-1.33.0 branch from 87f7b61 to 56fbf84 Compare December 5, 2024 06:39
@Sumynwa
Copy link

Sumynwa commented Dec 5, 2024

src/runtime build checks are now passing.
@arc9693 @ms-mahuber kindly review.

@Sumynwa Sumynwa merged commit 0126498 into msft-main Dec 6, 2024
46 of 55 checks passed
@Sumynwa Sumynwa deleted the dependabot/go_modules/src/runtime/google.golang.org/protobuf-1.33.0 branch December 6, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants