Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-builder: Adapt README instructions #240

Merged
merged 1 commit into from
Oct 11, 2024
Merged

node-builder: Adapt README instructions #240

merged 1 commit into from
Oct 11, 2024

Conversation

ms-mahuber
Copy link

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary
  • Sanitize containerd config snippet
  • Set podOverhead for Kata runtime class
Test Methodology
  • Manual deployments

@ms-mahuber
node-builder: Adapt README instructions
c7698d7 
- Sanitize containerd config snippet
- Set podOverhead for Kata runtime class

Signed-off-by: Manuel Huber <[email protected]>
@ms-mahuber ms-mahuber added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Oct 11, 2024
@ms-mahuber ms-mahuber requested review from a team as code owners October 11, 2024 21:41
@ms-mahuber ms-mahuber merged commit 6e8cc06 into msft-main Oct 11, 2024
44 of 57 checks passed
sprt pushed a commit that referenced this pull request Feb 10, 2025
@ms-mahuber @sprt
Merge pull request #240 from microsoft/mahuber/build/readme-fixes
aa42b2a 
node-builder: Adapt README instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miz060 miz060 miz060 approved these changes

Assignees
No one assigned
Labels
upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-mahuber @miz060