Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr_template: remove genpolicy windows support #239

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Redent0r
Copy link

@Redent0r Redent0r commented Oct 9, 2024

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

pr_template: remove genpolicy windows support
check from PR template

We don't support genpolicy for windows as of 3.2.0.azl1.genpolicy1

Test Methodology

n/a

@Redent0r Redent0r changed the base branch from main to msft-main October 9, 2024 22:40
@Redent0r Redent0r requested review from a team as code owners October 9, 2024 22:40
@sprt
Copy link
Collaborator

sprt commented Oct 9, 2024

Could you fix the PR title?

Also note from the contributing guide:

The body of the message is not a continuation of the subject line and is not used to extend the subject line beyond its character limit. The subject line is a complete sentence and the body is a complete, standalone paragraph.

@Redent0r Redent0r changed the title Saulparedes/remove windows from template pr_template: remove genpolicy windows support Oct 9, 2024
@Redent0r Redent0r added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Oct 9, 2024
We don't support genpolicy for windows as of 3.2.0.azl1.genpolicy1

Signed-off-by: Saul Paredes <[email protected]>
@Redent0r
Copy link
Author

Redent0r commented Oct 9, 2024

The body of the message is not a continuation of the subject line and is not used to extend the subject line beyond its character limit. The subject line is a complete sentence and the body is a complete, standalone paragraph.

Thanks! looks like I need to fix my vs code settings for commit messages
image

I thought the first line capped at 75 characters and I was trying to respect the 75 character subject limit. But looks like that line is actually set at 50 characters. I've been shortening my subject line way more than needed all this time lol

@Redent0r Redent0r force-pushed the saulparedes/remove_windows_from_template branch from d192f6f to 31edf1f Compare October 9, 2024 23:21
@Redent0r Redent0r merged commit 0d4524c into msft-main Oct 14, 2024
42 of 53 checks passed
@Redent0r Redent0r deleted the saulparedes/remove_windows_from_template branch October 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants