Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-builder: introduce SHIM_REDEPLOY_CONFIG #226

Merged
merged 1 commit into from
Aug 30, 2024
Merged

node-builder: introduce SHIM_REDEPLOY_CONFIG #226

merged 1 commit into from
Aug 30, 2024

Conversation

sprt
Copy link
Collaborator

@sprt sprt commented Aug 29, 2024 •
edited
Loading

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

See commit.

Test Methodology

NOT tested by me yet.

@sprt sprt marked this pull request as ready for review August 29, 2024 22:25
@sprt sprt requested review from a team as code owners August 29, 2024 22:25
@sprt
node-builder: introduce SHIM_REDEPLOY_CONFIG
a53640c 
See README: when SHIM_REDEPLOY_CONFIG=no, the shim configuration is NOT
redeployed, so that potential config changes made directly on the host
during development aren't lost.

Signed-off-by: Aurélien Bombo <[email protected]>
@sprt sprt force-pushed the sprt/build-recipe-bugbash branch from e309175 to a53640c Compare August 30, 2024 18:18
@sprt sprt merged commit 75a11db into msft-main Aug 30, 2024
44 of 55 checks passed
@sprt sprt added the upstream/missing PRs that are yet to be upstreamed label Sep 9, 2024
sprt added a commit that referenced this pull request Feb 10, 2025
@sprt
Merge pull request #226 from microsoft/sprt/build-recipe-bugbash
da3f220 
node-builder: introduce SHIM_REDEPLOY_CONFIG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmihai1 danmihai1 danmihai1 approved these changes

@ms-mahuber ms-mahuber ms-mahuber approved these changes

Assignees
No one assigned
Labels
upstream/missing PRs that are yet to be upstreamed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sprt @danmihai1 @ms-mahuber