Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Enable setting IGVM SVN #224

Merged
merged 1 commit into from
Aug 23, 2024
Merged

tools: Enable setting IGVM SVN #224

merged 1 commit into from
Aug 23, 2024

Conversation

ms-mahuber
Copy link

@ms-mahuber ms-mahuber commented Aug 23, 2024

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

Allow setting SVN parameter for IGVM build scripting

Test Methodology

Ran IGVM_SVN=10 make all-confpods. This yields the following:

...
/home/azureuser/kata-containers/tools/osbuilder/igvm-builder/igvm_builder.sh -o /home/azureuser/kata-containers/tools/osbuilder -s 10
IGVM builder script
-- OUT_DIR -> /home/azureuser/kata-containers/tools/osbuilder
-- SVN -> 10
-- DISTRO -> azure-linux
-- MODE -> build
igvm_lib.sh file found. Loading content
Reading Kata image dm_verity root hash information from root_hash file
igvm_lib.sh file found. Loading content
Building (debug) IGVM files and creating their reference measurement files
{'x-ms-sevsnpvm-guestsvn': '10', 'x-ms-sevsnpvm-launchmeasurement': '2785583f67d6a72a4e3f4ac3945ca6ee10bf59d2b12d865e5e16f1dc2b4e9db5a99e22eeb6f2fd8277fc6e4747369557'}
{'x-ms-sevsnpvm-guestsvn': '10', 'x-ms-sevsnpvm-launchmeasurement': '7dd8dfccfc094dd3311ab286346f96fcb2176e7212be70bf3a5104855adc9a578e6eb6507dccaa5ceff45514e0062d54'}

...

- Allow setting SVN parameter for IGVM build scripting

Signed-off-by: Manuel Huber <[email protected]>
@ms-mahuber ms-mahuber added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Aug 23, 2024
@ms-mahuber ms-mahuber marked this pull request as ready for review August 23, 2024 19:06
@ms-mahuber ms-mahuber requested review from a team as code owners August 23, 2024 19:06
@ms-mahuber ms-mahuber merged commit d375a69 into msft-main Aug 23, 2024
47 of 106 checks passed
sprt pushed a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants