Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Improve igvm-builder and node-builder/azure-linux scripting #204

Merged
merged 1 commit into from
Jul 15, 2024
Merged

tools: Improve igvm-builder and node-builder/azure-linux scripting #204

merged 1 commit into from
Jul 15, 2024

Conversation

ms-mahuber
Copy link

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary
  • Support for Mariner 3 builds using OS_VERSION variable
  • Improvements to IGVM build process and flow as described in README
  • Adoption of using only cloud-hypervisor-cvm on CBL-Mariner
Test Methodology
  • Manual build paths

@ms-mahuber ms-mahuber added the upstream/missing PRs that are yet to be upstreamed label Jul 4, 2024
@ms-mahuber ms-mahuber requested review from a team as code owners July 4, 2024 18:37
danmihai1
danmihai1 requested changes Jul 8, 2024
View reviewed changes
Copy link

@danmihai1 danmihai1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ms-mahuber , is it practical to split this PR into multiple ones? I hope we can review smaller diffs.

@ms-mahuber ms-mahuber mentioned this pull request Jul 11, 2024
Merged
5 tasks
@ms-mahuber
tools: Improve igvm-builder and node-builder/azure-linux scripting
2f672a1 
- Support for Mariner 3 builds using OS_VERSION variable
- Improvements to IGVM build process and flow as described in README
- Adoption of using only cloud-hypervisor-cvm on CBL-Mariner

Signed-off-by: Manuel Huber <[email protected]>
@ms-mahuber ms-mahuber force-pushed the mahuber/uvm-spec-build-pr branch from b2d2317 to 2f672a1 Compare July 15, 2024 18:56
@ms-mahuber ms-mahuber merged commit dd57910 into msft-main Jul 15, 2024
44 of 55 checks passed
sprt pushed a commit that referenced this pull request Feb 10, 2025
@ms-mahuber @sprt
Merge pull request #204 from microsoft/mahuber/uvm-spec-build-pr
3a35ae4 
tools: Improve igvm-builder and node-builder/azure-linux scripting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmihai1 danmihai1 danmihai1 approved these changes

Assignees
No one assigned
Labels
upstream/missing PRs that are yet to be upstreamed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ms-mahuber @danmihai1