Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add check for policy samples #186

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

sprt
Copy link
Collaborator

@sprt sprt commented Apr 29, 2024

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
  • The upstream-missing label (or upstream-not-needed) has been set on the PR.
Summary
This adds a GitHub Action workflow to check that the policy samples have
been updated with each PR. We'll add it as a required check to catch
policy errors earlier in the dev process.

I also tweaked the update script to have better error handling, and I
simplified the PR template to make it more readable.

@sprt sprt added upstream/not-needed PRs that will not be upstreamed (e.g. internal) and removed upstream/not-needed PRs that will not be upstreamed (e.g. internal) labels Apr 30, 2024
@sprt sprt force-pushed the sprt/workflow-update-samples branch 3 times, most recently from faafe92 to 9d57d17 Compare May 3, 2024 15:08
@sprt sprt added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label May 7, 2024
@sprt sprt force-pushed the sprt/workflow-update-samples branch from 58546b7 to 0e36c05 Compare May 7, 2024 17:26
@sprt sprt changed the title ci: check samples ci: add check for policy samples May 7, 2024
@sprt sprt force-pushed the sprt/workflow-update-samples branch from 0e36c05 to b88bf84 Compare May 7, 2024 17:33
@sprt sprt marked this pull request as ready for review May 7, 2024 17:35
@sprt sprt requested review from a team as code owners May 7, 2024 17:35
Copy link

@Redent0r Redent0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @sprt, thank you!

I did noticed the check is not showing as required yet
image

Not sure if it'll change to required once it's merged

@sprt
Copy link
Collaborator Author

sprt commented May 7, 2024

@Redent0r Will add it as required when we merge it!

@sprt sprt force-pushed the sprt/workflow-update-samples branch 2 times, most recently from aeba35c to e91a453 Compare May 7, 2024 19:11
This adds a GitHub Action workflow to check that the policy samples have
been updated with each PR. We'll add it as a required check to catch
policy errors earlier in the dev process.

I also tweaked the update script to have better error handling, and I
simplified the PR template to make it more readable.

Signed-off-by: Aurélien Bombo <[email protected]>
@sprt sprt force-pushed the sprt/workflow-update-samples branch from e91a453 to 949f8c8 Compare May 7, 2024 19:13
@sprt sprt merged commit a004ef0 into msft-main May 7, 2024
44 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream/not-needed PRs that will not be upstreamed (e.g. internal)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants