forked from kata-containers/kata-containers
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genpolicy: add --version flag #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmihai1
reviewed
Apr 15, 2024
sprt
reviewed
Apr 15, 2024
Also to update the release process in the wiki to bump the version number. |
ffc72e5
to
18485ae
Compare
Just force pushed following changes:
|
Redent0r
commented
Apr 16, 2024
041e9be
to
b3901b1
Compare
sprt
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments. Also shouldn't we rather create this PR upstream?
410ca1a
to
070d7e1
Compare
danmihai1
approved these changes
Apr 17, 2024
sprt
approved these changes
Apr 17, 2024
- Add --version flag to the genpolicy tool that prints the current version - Add version.rs.in template to store the version information - Update makefile to autogenerate version.rs from version.rs.in - Add license to Cargo.toml Signed-off-by: Saul Paredes <[email protected]>
070d7e1
to
a067b65
Compare
Addressed feedback and corrected commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a --version flag to the genpolicy tool that prints the current version
Merge Checklist
upstream-missing
label (orupstream-not-needed
) has been set on the PR.Summary
Add --version flag
`
$ target/debug/genpolicy -v
Kata Containers policy tool (Rust): id: genpolicy, version: 3.2.0-azl0.genpolicy1, commit: ffc72e5
`
dev: instead of
cargo build
, we'd useLIBC=gnu BUILD_TYPE= make
(cargo build
still works, but you'll need to useLIBC=gnu BUILD_TYPE= make
the first time at least to generate version.rs and not get a compile error)release: instead of
cargo build --release
, we'd useLIBC=gnu make
(Here we'll want to stick toLIBC=gnu make
as this will embed the correct commit information to release binary)Make build method is incompatible on Windows. For Windows releases:
src/version.rs
with correct commit infocargo build --release