Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tarindex: Add special symlink name handling #159

Merged
merged 1 commit into from
Mar 5, 2024
Merged

tarindex: Add special symlink name handling #159

merged 1 commit into from
Mar 5, 2024

Conversation

miz060
Copy link
Member

@miz060 miz060 commented Feb 7, 2024 •
edited
Loading

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
  • The upstream-missing label (or upstream-not-needed) has been set on the PR.
Summary

Enable tarindex to handle symlink name with special characters or length longer than the 100 limit by duplicating it before the string table.

Test Methodology
  • Local testing with tarindex execuatable.
  • Manual AKS cluster testing with "registry.k8s.io/e2e-test-images/agnhost:2.40" image. This update creates the previously skipped /etc/ssl/certs/ca-cert-NetLock_Arany_=Class_Gold=_Főtanúsítvány.pem symlink.
  • RPM build: 510540
  • Image build: 510563
  • Conformance test: 510729
  • Performance test: 510730

@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch from ab3e4b9 to 933938e Compare February 21, 2024 19:15
@miz060 miz060 marked this pull request as ready for review February 22, 2024 19:11
@miz060 miz060 requested review from a team as code owners February 22, 2024 19:11
@miz060 miz060 changed the title Add special symlink name handling in tarindex tarindex: Add special symlink name handling Feb 22, 2024
@miz060 miz060 added the upstream/missing PRs that are yet to be upstreamed label Feb 22, 2024
@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch from ada8ed7 to 8600886 Compare February 22, 2024 19:19
@ms-mahuber
Copy link

The change needs to target our fork because the part of the code we fix is not upstreamed yet?

@miz060
Copy link
Member Author

miz060 commented Feb 22, 2024

The change needs to target our fork because the part of the code we fix is not upstreamed yet?

That's correct.

danmihai1
danmihai1 requested changes Feb 22, 2024
View reviewed changes
@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch 2 times, most recently from 138d803 to a33e6af Compare February 26, 2024 16:56
ms-mahuber
ms-mahuber approved these changes Feb 26, 2024
View reviewed changes
sprt
sprt requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@sprt sprt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash your commits into one?

@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch from a33e6af to 5257c38 Compare February 26, 2024 18:09
@miz060
Copy link
Member Author

miz060 commented Feb 26, 2024

Could you squash your commits into one?

Yes, squashed now.

@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch from 5257c38 to f12ae15 Compare February 26, 2024 18:20
@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch from f12ae15 to 919f054 Compare February 26, 2024 21:51
@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch from 919f054 to 7660dd1 Compare March 5, 2024 00:43
wedsonaf
wedsonaf approved these changes Mar 5, 2024
View reviewed changes
Copy link

@wedsonaf wedsonaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple of nits.

@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch from 7660dd1 to 5769210 Compare March 5, 2024 03:45
@miz060
tarindex: Add special symlink name handling
3951807 
Enable tarindex to handle symlink names with special characters or
length longer than the 100 limit.

Signed-off-by: Mitch Zhu <[email protected]>
@miz060 miz060 force-pushed the mitchzhu/genpolicy_fix_long_link_name_pr branch from 5769210 to 3951807 Compare March 5, 2024 18:13
@miz060 miz060 merged commit daba467 into msft-main Mar 5, 2024
43 of 54 checks passed
@Redent0r Redent0r mentioned this pull request Mar 13, 2024
Merged
6 tasks
@miz060 miz060 deleted the mitchzhu/genpolicy_fix_long_link_name_pr branch June 7, 2024 18:55
sprt pushed a commit that referenced this pull request Feb 10, 2025
@miz060 @sprt
Merge pull request #159 from microsoft/mitchzhu/genpolicy_fix_long_li…
27e0f59 
…nk_name_pr

tarindex: Add special symlink name handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sprt sprt sprt approved these changes

@wedsonaf wedsonaf wedsonaf approved these changes

@danmihai1 danmihai1 danmihai1 approved these changes

@ms-mahuber ms-mahuber ms-mahuber approved these changes

Assignees
No one assigned
Labels
upstream/missing PRs that are yet to be upstreamed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miz060 @ms-mahuber @sprt @wedsonaf @danmihai1