Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add upstream-missing label to PR checklist #146

Closed
wants to merge 1 commit into from

Conversation

sprt
Copy link
Collaborator

@sprt sprt commented Jan 19, 2024

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
  • The upstream-needed label (or upstream-not-needed) has been set on the PR.
Summary

I've created 3 new PR labels our repo:

  • upstream-missing: PRs that are yet to be upstreamed.
  • upstream-not-needed: PRs that won't be merged upstream.
  • upstream-merged: PRs that have been merged upstream.

To facilitate tracking, from now on each PR should be initially tagged as upstream-missing or upstream-not-needed.

If a PR is created with upstream-not-needed, its description should explain why it won't be upstreamed unless it's directly obvious.

When a change is merged upstream, the PR label should be changed to upstream-merged and a comment should be added linking to the upstream PR.

I've created 3 new PR labels our repo:

 * `upstream-missing`: PRs that are yet to be upstreamed.
 * `upstream-not-needed`: PRs that have been merged upstream.
 * `upstream-merged`: PRs that have been merged upstream.

To facilitate tracking, from now on each PR should be initially tagged
as `upstream-missing` or `upstream-not-needed`.

If a PR is created with `upstream-not-needed`, its description should
explain why it won't be upstreamed unless it's directly obvious.

When a change is merged upstream, the PR label should be changed to
`upstream-merged` and a comment should be added linking to the upstream
PR.

Signed-off-by: Aurélien Bombo <[email protected]>
@sprt sprt added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Jan 19, 2024
@sprt sprt closed this Jan 19, 2024
@sprt sprt removed the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant