-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genpolicy: add priorityClassName as a field in PodSpec interface #145
Conversation
Thank you @arc9693! To keep testing and ensure this functionality going forward, could you add a priorityClass to https://github.com/microsoft/kata-containers/blob/msft-main/src/agent/samples/policy/yaml/pod/pod-ubuntu.yaml or a simmilar existing yaml, update the annotation, and trigger a pipeline test run on this branch (https://dev.azure.com/mariner-org/mariner/_wiki/wikis/mariner.wiki/3368/Testing-genpolicy)? |
Thanks for the reminder, Saul! Archana, please keep the YAML file change in a separate commit. That should make upstreaming your change a bit easier for now - until we'll be ready to make these improvements directly upstream. |
400dbdc
to
8a64aea
Compare
I have updated the mentioned yaml, although there was no update in the annotation. |
27b6c01
to
066ea49
Compare
This allows generation of policy for pods specifying priority classes. Signed-off-by: Archana Choudhary <[email protected]>
066ea49
to
9a0011d
Compare
Adds priorityClassName to the test yaml file Signed-off-by: Archana choudhary <[email protected]>
9a0011d
to
9ec2441
Compare
Updated the PriorityClass spec's api version. Triggered: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=493908&view=results. Tested in local. |
Merge Checklist
Summary
Adds priorityClassName as a field in PodSpec interface.
This change allows generation of policy for pods specifying priority classes, which currently fails.
Associated issues
Links to CVEs
Test Methodology
Generated a policy for pod having priorityClassName and created the pod on K8s with kata-cc runtime.