Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR #143

Closed
wants to merge 393 commits into from
Closed

Test PR #143

wants to merge 393 commits into from

Conversation

sprt
Copy link
Collaborator

@sprt sprt commented Jan 17, 2024

No description provided.

GabyCT and others added 30 commits December 8, 2023 16:12
This PR enables the nerdctl tests for cloud hypervisor runtime-rs.

Fixes kata-containers#8616

Signed-off-by: Gabriela Cervantes <[email protected]>
…-inheritance-s390x

GHA: make secrets inherited for build-kata-static-tarball-s390x
If a wrong configuration.toml file is used by accidentally, runtime-rs
binary could run into panic because of unwrap().

This fixes the panic by returning errors instead of unwrap().

fixes: kata-containers#8565

Signed-off-by: Liu Bo <[email protected]>
Only attempt to build the markdown checker if it doesn't already exist.

Signed-off-by: James O. D. Hunt <[email protected]>
Break up a long line as little to make it easier to read.

Signed-off-by: James O. D. Hunt <[email protected]>
Check that the `check_url()` parameters have a value.

Signed-off-by: James O. D. Hunt <[email protected]>
Declare and then define a couple of variables separately.

Signed-off-by: James O. D. Hunt <[email protected]>
Split the call to `curl` in the URL checker out into a new
`run_url_check_cmd()` function to make `check_url()` slightly clearer.

Signed-off-by: James O. D. Hunt <[email protected]>
Remove some extraneous whitespace.

Signed-off-by: James O. D. Hunt <[email protected]>
Removed the Azure Portal URL (https://portal.azure.com) since this
causes problems with our static checks script: that URL returns HTTP 403
("Forbidden") when queried using command-line tools like `curl(1)`,
which is used by the static check script.

Signed-off-by: James O. D. Hunt <[email protected]>
Make the URL checker cycle through a list of user agent values until we
hit one the remote server is happy with.

This is required since, unfortunately, we really, really want to check
these URLs, but some sites block clients based on their `User-Agent`
(UA) request header value. And of course, each site is different and can
change its behaviour at any time.

Our strategy therefore is to try various UA's until we find one the
server accepts:

- No explicit UA (use `curl`'s default)
- Explicitly no UA.
- A blank UA.
- Partial UA values for various CLI tools.
- Partial UA values for various console web browsers.
- Partial UA for Emacs's built-in browser.
- The existing UA which is used as a "last ditch" attempt where the UA implies multiple platforms and browser.

> **Notes:**
>
> - The "partial UA" values specify specify the UA "product" but not the
>   UA "product version": we specify `foo` and not `foo/1.2.3`). We do
>   this since most sites tested appear to not care about the version.
>   This is as expected given that the version is strictly optional (see `[*]`).
>
> - We now log all errors and display an error summary if none of the UAs
>   worked, in addition to the simple list of the URLs we believe to be
>   invalid. This should make future debugging simpler.

`[*]` - https://www.rfc-editor.org/rfc/rfc9110#section-10.1.5

Fixes: kata-containers#8553.

Signed-off-by: James O. D. Hunt <[email protected]>
kata-ctl: Moved log-parser-rs into kata-ctl
This PR adds the cloud hypervisor in the enabling hypervisor function.

Signed-off-by: Gabriela Cervantes <[email protected]>
…nic_fix

runtime-rs: fix panic when hypervisor mismatches with configuration
This is to fix a broken usage for `k3s kubectl version` by switching
an option `--short` to `--client=true`.

Fixes: kata-containers#8621

Signed-off-by: Hyounggyu Choi <[email protected]>
…tl-version

GHA: Use --client=true for k3s kubectl version
This is to fix an error on kata-deploy-runtime-classes-check for kata-qemu-se.

Fixes: kata-containers#8623

Signed-off-by: Hyounggyu Choi <[email protected]>
…-try-multiple-user-agents

CI: static-checks: Try multiple user agents
…s-check-qemu-se

GHA: Fix kata-deploy-runtime-classes-check for kata-qemu-se
This PR is to build a binary for OPA from source code for ppc64le and s390x.

Fixes: kata-containers#7616

Signed-off-by: Hyounggyu Choi <[email protected]>
Right now, cargo fmt check in Dragonball only test with the default
features but not all features. This will cause some code being untested
by the fmt tool.

This PR adds --all option for the Dragonball CI and also fix some code
that forgets to do cargo fmt --all.

fixes: kata-containers#8598

Signed-off-by: Chao Wu <[email protected]>
rootfs: build OPA binary from source for ppc64le and s390x
gha: k8s: Add cloud-hypervisor (runtime-rs) support
…loyment_cleaning

metrics: cleans k8s iperf deployment when the test finishes.
…erdctl

tests: nerdctl: Enable nerdctl tests for cloud hypervisor runtime-rs
In order to follow up the PCI implementation in Dragonball, we need to
add PCI root device and root bus support.

root device is a pseudo PCI root device to manage accessing to PCI
configuration space.

root bus is mainly for emulating PCI root bridge and also create the PCI
root bus with the given bus ID with the PCI root bridge.

fixes: kata-containers#8563

Signed-off-by: Gerry Liu <[email protected]>
Signed-off-by: Zizheng Bian <[email protected]>
Signed-off-by: Shifang Feng <[email protected]>
Signed-off-by: Yang Su <[email protected]>
Signed-off-by: Zha Bin <[email protected]>
Signed-off-by: Xin Lin <[email protected]>
Signed-off-by: Chao Wu <[email protected]>
The layout of packed virtqueue isn't supported by `Endpoint::negotiate()`.
Communication between device and driver will be failed due to the failure
of parsing virtqueue if we don't disable the packed feature. This patch
fixes this issue.

Fixes: kata-containers#8633

Signed-off-by: Xuewei Niu <[email protected]>
Fix paths for yqdir (where the install_yq.sh script currently is) so
that static checks can run without error.

Fixes kata-containers#8595

Signed-off-by: Chelsea Mafrica <[email protected]>
Add a `--show-default-config-paths` command line option for parity with
`kata-runtime`.

Note that this requires the `KataCtlCli.command` to be optional so that
the user can run simply:

```bash
$ kata-ctl --show-default-config-paths
```

... without also specifying a (sub-)command.

Fixes: kata-containers#8640.

Signed-off-by: James O. D. Hunt <[email protected]>
GabyCT and others added 25 commits January 11, 2024 22:15
This PR uses a specific python version to run tensorflow benchmark
as it needs python 3.8 to run correctly and avoid failures.

Fixes kata-containers#8791

Signed-off-by: Gabriela Cervantes <[email protected]>
…untime-rs-ch-rm-todo-to-unbreak

runtime-rs: ch: Unbreak CH driver
…-containerd

ci: enable test dragonball stability and cri-containerd
metrics: Use a specific python version to run tensorflow benchmark
Also, update Cargo.lock

Fixes: kata-containers#8816

Signed-off-by: Dan Mihai <[email protected]>
`EndpointProtocolFlags::ProtocolBackend` is removed due to no reference.

Fixes: kata-containers#8745

Signed-off-by: Xuewei Niu <[email protected]>
…o-fmt

genpolicy: "cargo fmt -- --check" clean-up
Clean up cargo clippy errors.

Fixes: kata-containers#8818

Signed-off-by: Dan Mihai <[email protected]>
Disable k8s-oom.bats on cbl-mariner until it passes more often.

Fixes: kata-containers#8824

Signed-off-by: Dan Mihai <[email protected]>
…ackend

dragonball: Remove unused definition
…ble-k8s-oom

tests: cbl-mariner: disable k8s-oom.bats
This PR removes the iperf3 server protocol as this server definition is
also used for the UDP iperf3 benchmarks to avoid duplication of the
same yaml files.

Fixes kata-containers#8829

Signed-off-by: Gabriela Cervantes <[email protected]>
This PR removes the references to virtiofs from memory average
calculation when the container uses a shared file system other than
virtiofs.

Fixes: kata-containers#8807

Signed-off-by: David Esparza <[email protected]>
Package genpolicy and enable static checks for it.

Fixes: kata-containers#8813

Signed-off-by: Dan Mihai <[email protected]>
Adjust genpolicy-settings.json to match the container root path from
the main branch + cbl-mariner Guest VMs.

This configuration might have to be adjusted again when other types of
Guest VMs will be tested during CI using genpolicy, in the future.

Also, improve logging from allow_root_path(), to easier debug these
issues in the future.

Fixes: kata-containers#8835

Signed-off-by: Dan Mihai <[email protected]>
Temporarily disable the allow_storages() rules, because they are based
on the tarfs snapshotter + container image integrity information that
are not available yet in the main branch - see kata-containers#8833.

Fixes: kata-containers#8834

Signed-off-by: Dan Mihai <[email protected]>
DirectVolume/Rawblock doesn't work well when device's block driver
is virtio-blk-pci and the storage handler is DRIVER_BLK_PCI_TYPE.

Fixes: kata-containers#8707

Signed-off-by: alex.lyn <[email protected]>
…x-blk-pci

runtime-rs: bugfix for DirectVolume/rawblock when driver is blk
…w_storages

genpolicy: temporarily disable allow_storages()
…olicy-kata-deploy

tools: genpolicy static checks
…sage_test_skip_virtiofs_when_req

tests: Ignore virtiofs contribution to memory usage when it is disabled.
…-with-cbl-mariner

genpolicy: use root path from cbl-mariner Guest VM
Signed-off-by: Aurélien Bombo <[email protected]>
@sprt sprt changed the base branch from main to msft-main January 17, 2024 21:12
@sprt sprt marked this pull request as ready for review January 17, 2024 21:13
@sprt sprt closed this Jan 17, 2024
@sprt sprt removed the do-not-merge label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.