This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Data Skipping Index Part 1: Refactoring #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 28, 2021 18:48
Until the issue microsoft#484 is fixed.
- Replace CoveringIndexFilter with a generic IndexTypeFilter so that it can be reused for DataSkippingIndex. - Rename RuleUtils to CoveringIndexRuleUtils and extract methods not specific to CoveringIndex into RuleUtils so that DataSkippingIndex can use them. - Move ExtractRelation from index.covering to index.rules because it is a general extractor that can be used by DataSkippingIndex.
This was referenced Jul 28, 2021
sezruby
approved these changes
Jul 29, 2021
clee704
added
the
refactoring
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can be reused for DataSkippingIndex.
specific to CoveringIndex into RuleUtils so that DataSkippingIndex can
use them.
a general extractor that can be used by DataSkippingIndex.
What is the context for this pull request?
What changes were proposed in this pull request?
Reorganize code so that code duplication is minimized when new index types are added later.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests