Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Issue 400 scalafmt #418

Closed

Conversation

dmytroDragan
Copy link

What is the context for this pull request?

What changes were proposed in this pull request?

Files (which were changed in #417) were missing scalafmt formatting.
As result PR-417 is hard to review due to mix of issue fix and scalafmt formatting.

To resolve it, the simplest approach is to apply scalafmt formatting in first place.
After merging this PR PR-417 should be unblocked.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

Copy link
Contributor

@andrei-ionescu andrei-ionescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These methods being moved around will cause substantial conflicts in other PRs. Is this really necessary? Can we check what's the impact on the current opened PRs?

@sezruby
Copy link
Collaborator

sezruby commented Apr 15, 2021

@andrei-ionescu All changes are from rearrangement and I think it looks no problem. Which change are you concerned?

@imback82
Copy link
Contributor

Hmm, I don't think we should enforce rearrangement with scalafmt since it is not consistent with other files. Can you please turn if off?

When I run scalafmt on IndexLogEntry.scala, I see "No lines changed: content is already properly formatted". @sezruby / @andrei-ionescu what do you see?

@dmytroDragan
Copy link
Author

OK, I have turned it off. i guess it would be good to add a note about it to contribution guide.
This PR in this case is obsolete. I will update #417

@imback82
Copy link
Contributor

Thanks @dmytroDragan, will update the contribution guide.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants