Update dependencies to fix panic in go generate #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the crash when go generating Signed-off-by: Mathieu Champlon <[email protected]>
mat007
force-pushed
the
fix-go-generate
branch
from
c864d0f to
60571b8
Compare
mat007
changed the title
thaJeztah
reviewed
Jan 30, 2025
go.mod
Outdated
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| toolchain go1.22.10 |
There was a problem hiding this comment.
You can probably remove this one if it automatically added it (go modules tends to randomly add these, but adding also means that users get either down- or upgraded when running commands, so I try to avoid adding these.
| @@ -1,11 +1,16 @@ | |||
| module github.com/Microsoft/go-winio | |||
|
|
|||
| go 1.21 | |||
| go 1.22.0 | |||
There was a problem hiding this comment.
Did the updated modules enforce updating to go1.22.0, or does it accept staying on go1.21 ?
There was a problem hiding this comment.
Yes, it needs go 1.22:
$ GOTOOLCHAIN=go1.21.0 go get golang.org/x/tools/cmd/stringer
go: golang.org/x/tools/cmd/stringer: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.0; GOTOOLCHAIN=go1.21.0)
Signed-off-by: Mathieu Champlon <[email protected]>
mat007
force-pushed
the
fix-go-generate
branch
from
2019b42 to
ebe1a7d
Compare
|
@kiashok can you trigger the CI again? |
|
All right, so this effectively fixes the «CI / Go Generate» workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I picked Go 1.22 because I’ve seen this in another recent PR run:
Also updating
golang.org/x/tools/cmd/stringerrequires Go 1.22:Here is what I did:
then manually edited
go.modto remove the addedtoolchain, and re-rango mod tidyto make sure it’s stable.