Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(react-tag-picker): regression from #33689 #33747

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Jan 30, 2025

Previous Behavior

PR #33689 introduced a regression whenever a TagpickerOption is without secondaryContent, this regression wasn't caught by our VR pipelines because there were no stories without secondaryContent

image

New Behavior

  1. fix regression
  2. modify default story to not include secondaryContent to ensure this will be caught in VR

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Jan 30, 2025
@bsunderhus bsunderhus marked this pull request as ready for review January 30, 2025 08:36
@bsunderhus bsunderhus requested a review from a team as a code owner January 30, 2025 08:36
Copy link

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.169 MB
292.865 kB
1.169 MB
292.874 kB
-106 B
9 B
react-tag-picker
@fluentui/react-tag-picker - package
185.766 kB
55.766 kB
185.663 kB
55.782 kB
-103 B
16 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.236 kB
20.182 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
224.18 kB
64.859 kB
react-components
react-components: FluentProvider & webLightTheme
44.473 kB
14.597 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-timepicker-compat
TimePicker
108.551 kB
36.094 kB
🤖 This report was generated against 18595df3b1ed1b5376ef665748aec8b8602746e3

Copy link

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants