fix(react-color picker) Thumb design #33743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinaKozlova
force-pushed
the
fix/color-picker-thumb-design
branch
from
093a1ec to
651be52
Compare
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
fabricteam
reviewed
Jan 29, 2025
change/@fluentui-react-color-picker-preview-66c948a0-e330-4f71-a4f0-d9d7cf4ed771.json
Show resolved
Hide resolved
dmytrokirpa
approved these changes
Jan 30, 2025
...nts/react-color-picker-preview/library/src/components/ColorArea/useColorAreaStyles.styles.ts
Outdated
Show resolved
Hide resolved
...react-color-picker-preview/library/src/components/ColorSlider/useColorSliderStyles.styles.ts
Outdated
Show resolved
Hide resolved
...react-color-picker-preview/library/src/components/ColorSlider/useColorSliderStyles.styles.ts
Outdated
Show resolved
Hide resolved
...nts/react-color-picker-preview/library/src/components/ColorArea/useColorAreaStyles.styles.ts
Outdated
Show resolved
Hide resolved
…rc/components/ColorArea/useColorAreaStyles.styles.ts Co-authored-by: Dmytro Kirpa <[email protected]>
…rc/components/ColorSlider/useColorSliderStyles.styles.ts Co-authored-by: Dmytro Kirpa <[email protected]>
…rc/components/ColorSlider/useColorSliderStyles.styles.ts Co-authored-by: Dmytro Kirpa <[email protected]>
…rc/components/ColorArea/useColorAreaStyles.styles.ts Co-authored-by: Dmytro Kirpa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design changes of the thumb according to partner's feedback.
This is partner's design (dark theme):
They have different tokens for
box-shadowandborder-colorbut our new design uses V9 tokens close to partner's deisgn.Previous Behavior
light:
dark:
New Behavior
light:
dark: