Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single state #33727

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

single state #33727

wants to merge 2 commits into from

Conversation

ling1726
Copy link
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

fabricteam
fabricteam reviewed Jan 24, 2025
View reviewed changes
packages/react-components/react-combobox/library/src/components/Option/useOption.tsx
@@ -1,10 +1,11 @@
import * as React from 'react';
Copy link
Collaborator

@fabricteam fabricteam Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual regressions to review in the fluentuiv9 Visual Regression Report

Avatar Converged 1 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.Badge Mask RTL.chromium.png 5 Changed
Combobox Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Combobox Converged.Disabled option.chromium.png 56 Changed
Combobox Converged.With multiselect selection.chromium.png 12 Changed
Drawer 2 screenshots
Image Name Diff(in Pixels) Image Type
Drawer.Full Overlay High Contrast.chromium.png 6 Changed
Drawer.Full Overlay Dark Mode.chromium.png 975 Changed
Dropdown Converged 2 screenshots
Image Name Diff(in Pixels) Image Type
Dropdown Converged.Disabled option.chromium.png 56 Changed
Dropdown Converged.With multiselect selection.chromium.png 12 Changed
Menu 3 screenshots
Image Name Diff(in Pixels) Image Type
Menu.Nested Submenus Small Viewport Flipped.chromium.png 14 Changed
Menu.Nested Submenus Small Viewport Stacked.chromium.png 14 Changed
Menu.Scrollable Menu Small Viewport.chromium.png 10 Changed
Menu Converged - MenuItemLinks 1 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - MenuItemLinks.default.chromium.png 14 Changed
Menu Converged - basic 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - basic.Default RTL.chromium.png 13 Changed
Menu Converged - basic.default.chromium.png 14 Changed
Menu Converged - groups 4 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - groups.Default Dark Mode.chromium.png 329 Changed
Menu Converged - groups.Default High Contrast.chromium.png 2754 Changed
Menu Converged - groups.Default RTL.chromium.png 13 Changed
Menu Converged - groups.default.chromium.png 14 Changed
Menu Converged - icon slotted content 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - icon slotted content.Default RTL.chromium.png 14 Changed
Menu Converged - icon slotted content.default.chromium.png 14 Changed
Menu Converged - long content 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - long content.Default RTL.chromium.png 13 Changed
Menu Converged - long content.default.chromium.png 14 Changed
Menu Converged - nested submenus 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - nested submenus.default.chromium.png 14 Changed
Menu Converged - nested submenus.Default RTL.chromium.png 14 Changed
Menu Converged - secondary content 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - secondary content.default.chromium.png 14 Changed
Menu Converged - secondary content.Default RTL.chromium.png 13 Changed
Menu Converged - selection 9 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - selection.Checkbox RTL.chromium.png 13 Changed
Menu Converged - selection.Switch Dark Mode.chromium.png 396 Changed
Menu Converged - selection.Checkbox High Contrast.chromium.png 2754 Changed
Menu Converged - selection.Checkbox Dark Mode.chromium.png 329 Changed
Menu Converged - selection.selectable with long text.chromium.png 61 Changed
Menu Converged - selection.Switch High Contrast.chromium.png 3341 Changed
Menu Converged - selection.Switch RTL.chromium.png 37 Changed
Menu Converged - selection.checkbox.chromium.png 14 Changed
Menu Converged - selection.switch.chromium.png 37 Changed
Menu Converged - selection groups 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - selection groups.default.chromium.png 14 Changed
Menu Converged - selection groups.Default RTL.chromium.png 13 Changed
Menu Converged - split item 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - split item.Default RTL.chromium.png 14 Changed
Menu Converged - split item.default.chromium.png 14 Changed
Menu Converged - submenuIndicator slotted content 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Converged - submenuIndicator slotted content.Default RTL.chromium.png 24 Changed
Menu Converged - submenuIndicator slotted content.default.chromium.png 24 Changed
Menu Multiline items 2 screenshots
Image Name Diff(in Pixels) Image Type
Menu Multiline items.Default RTL.chromium.png 15 Changed
Menu Multiline items.default.chromium.png 16 Changed
Menu nested within a MenuTrigger 1 screenshots
Image Name Diff(in Pixels) Image Type
Menu nested within a MenuTrigger.default.chromium.png 14 Changed
TagPicker 4 screenshots
Image Name Diff(in Pixels) Image Type
TagPicker.Default Open Dark Mode.chromium.png 1371 Changed
TagPicker.Default Open High Contrast.chromium.png 12194 Changed
TagPicker.Grouped High Contrast.chromium.png 12194 Changed
TagPicker.Grouped Dark Mode.chromium.png 1371 Changed

@github-actions GitHub Actions
Copy link

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-combobox
Combobox (including child components)		 105.562 kB
34.52 kB		 105.74 kB
34.603 kB		 178 B
83 B
react-combobox
Dropdown (including child components)		 106.186 kB
34.462 kB		 106.364 kB
34.527 kB		 178 B
65 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 224.18 kB
64.859 kB		 225.312 kB
65.164 kB		 1.132 kB
305 B
react-components
react-components: entire library		 1.169 MB
292.741 kB		 1.17 MB
293.014 kB		 854 B
273 B
react-menu
Menu (including children components)		 155.616 kB
46.882 kB		 156.749 kB
47.137 kB		 1.133 kB
255 B
react-menu
Menu (including selectable components)		 158.598 kB
47.478 kB		 159.731 kB
47.742 kB		 1.133 kB
264 B
react-tag-picker
@fluentui/react-tag-picker - package		 185.734 kB
55.759 kB		 185.912 kB
55.847 kB		 178 B
88 B
react-timepicker-compat
TimePicker		 108.551 kB
36.094 kB		 108.729 kB
36.159 kB		 178 B
65 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
Avatar		 49.329 kB
15.824 kB
react-avatar
AvatarGroup		 20.132 kB
7.976 kB
react-avatar
AvatarGroupItem		 63.473 kB
20.043 kB
react-breadcrumb
@fluentui/react-breadcrumb - package		 114.317 kB
31.702 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 69.236 kB
20.182 kB
react-components
react-components: FluentProvider & webLightTheme		 44.473 kB
14.597 kB
react-datepicker-compat
DatePicker Compat		 225.344 kB
63.793 kB
react-dialog
Dialog (including children components)		 100.513 kB
30.131 kB
react-overflow
hooks only		 12.808 kB
4.819 kB
react-persona
Persona		 56.22 kB
17.704 kB
react-popover
Popover		 130.32 kB
40.699 kB
react-portal-compat
PortalCompatProvider		 8.39 kB
2.64 kB
react-table
DataGrid		 161.06 kB
45.718 kB
react-table
Table (Primitives only)		 42.692 kB
13.862 kB
react-table
Table as DataGrid		 131.895 kB
36.579 kB
react-table
Table (Selection only)		 70.562 kB
20.007 kB
react-table
Table (Sort only)		 69.205 kB
19.618 kB
react-tags
InteractionTag		 15.225 kB
6.165 kB
react-tags
Tag		 29.098 kB
9.559 kB
react-tags
TagGroup		 82.745 kB
24.532 kB
react-teaching-popover
TeachingPopover		 91.711 kB
27.921 kB
react-tree
FlatTree		 147.295 kB
42.271 kB
react-tree
PersonaFlatTree		 148.04 kB
42.417 kB
react-tree
PersonaTree		 144.249 kB
41.27 kB
react-tree
Tree		 143.51 kB
41.149 kB
🤖 This report was generated against 87d6ba3bd577a8be9756f4d392b048083d8ef16a

@github-actions GitHub Actions
Copy link

Pull request demo site: URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January Project Cycle Q1 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@ling1726 @fabricteam