Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-charting): Centre align Gauge chart #33710

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix(react-charting): Centre align Gauge chart #33710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a259f41
fix: centre align gauge chart
Anush2303 Jan 23, 2025
db7fcaf
Add change file
Anush2303 Jan 23, 2025
987e240
fix: change in styles
Anush2303 Jan 23, 2025
5595e18
fix: update snapshots
Anush2303 Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-7de5fc28-d928-44e4-ae42-5c51737d6af8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Anush2303 marked this conversation as resolved.
Show resolved Hide resolved
"type": "patch",
"comment": "Centre align gauge chart",
"packageName": "@fluentui/react-charting",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions ...-charting/src/components/DeclarativeChart/__snapshots__/DeclarativeChartRTL.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4026,6 +4026,9 @@ exports[`DeclarativeChart Should render gaugechart in DeclarativeChart 1`] = `
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down
3 changes: 3 additions & 0 deletions packages/charts/react-charting/src/components/GaugeChart/GaugeChart.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ export const getStyles = (props: IGaugeChartStyleProps): IGaugeChartStyles => {
theme.fonts.medium,
'ms-GaugeChart',
{
alignItems: 'center',
display: 'flex',
flexDirection: 'column',
width: '100%',
height: '100%',
},
Expand Down
33 changes: 33 additions & 0 deletions ...es/charts/react-charting/src/components/GaugeChart/__snapshots__/GaugeChart.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ exports[`GaugeChart interaction and accessibility tests should show a callout wh
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -828,6 +831,9 @@ exports[`GaugeChart snapshot tests should not render min and max values of the g
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -1372,6 +1378,9 @@ exports[`GaugeChart snapshot tests should not render the legends when the hideLe
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -1563,6 +1572,9 @@ exports[`GaugeChart snapshot tests should render GaugeChart correctly 1`] = `
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -2152,6 +2164,9 @@ exports[`GaugeChart snapshot tests should render GaugeChart correctly in dark th
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -2729,6 +2744,9 @@ exports[`GaugeChart snapshot tests should render GaugeChart correctly when the l
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -3305,6 +3323,9 @@ exports[`GaugeChart snapshot tests should render a color from DataVizPalette for
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -3758,6 +3779,9 @@ exports[`GaugeChart snapshot tests should render a placeholder segment when the
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -4210,6 +4234,9 @@ exports[`GaugeChart snapshot tests should render the chart title correctly 1`] =
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -4800,6 +4827,9 @@ exports[`GaugeChart snapshot tests should render the chart value in fraction for
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down Expand Up @@ -5376,6 +5406,9 @@ exports[`GaugeChart snapshot tests should render the sublabel correctly 1`] = `
{
-moz-osx-font-smoothing: grayscale;
-webkit-font-smoothing: antialiased;
align-items: center;
display: flex;
flex-direction: column;
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
Expand Down
Loading