Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-charting): [BUG 12178] Add background to the SVGTooltipText #33696

Merged
merged 11 commits into from
Jan 30, 2025
Merged

fix(react-charting): [BUG 12178] Add background to the SVGTooltipText #33696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
54f4a83
feat: Add background to the SVGTooltipText
srmukher Jan 21, 2025
e6a99b0
feat(react-charting): color and pixel related changes for SCGTooltipText
srmukher Jan 24, 2025
c1b1a3c
adding change file
srmukher Jan 24, 2025
caf4403
Merge branch 'master' into users/srmukher/backgroundSVG
srmukher Jan 24, 2025
bacb80b
RTL support for background
srmukher Jan 29, 2025
afe44cf
Merge branch 'master' into users/srmukher/backgroundSVG
srmukher Jan 29, 2025
df3cb2c
Merge branch 'users/srmukher/backgroundSVG' of https://github.com/mic…
srmukher Jan 29, 2025
47dfc7f
Merge branch 'master' into users/srmukher/backgroundSVG
srmukher Jan 30, 2025
22d74eb
Updating test snapshots
srmukher Jan 30, 2025
662a9c5
Merge branch 'users/srmukher/backgroundSVG' of https://github.com/mic…
srmukher Jan 30, 2025
86bcb34
increasing max depth
srmukher Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-charting-dc39fef3-6772-4647-97e3-872cfb5dee19.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Add background to the SVGTooltipText",
"packageName": "@fluentui/react-charting",
"email": "[email protected]",
"dependentChangeType": "patch"
}
3 changes: 3 additions & 0 deletions packages/charts/react-charting/src/components/CommonComponents/CartesianChart.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,6 +554,7 @@ export class CartesianChartBase
}}
maxWidth={xAxisTitleMaximumAllowedWidth}
wrapContent={wrapContent}
theme={this.props.theme}
/>
)}
<g
Expand Down Expand Up @@ -602,6 +603,7 @@ export class CartesianChartBase
}}
maxWidth={yAxisTitleMaximumAllowedHeight}
wrapContent={wrapContent}
theme={this.props.theme}
/>
)}
</g>
Expand All @@ -625,6 +627,7 @@ export class CartesianChartBase
}}
maxWidth={yAxisTitleMaximumAllowedHeight}
wrapContent={wrapContent}
theme={this.props.theme}
/>
)}
</svg>
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/react-charting/src/components/DeclarativeChart/PlotlySchemaAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ export const transformPlotlyJsonToGaugeProps = (
};
};

const MAX_DEPTH = 8;
const MAX_DEPTH = 15;
export const sanitizeJson = (jsonObject: any, depth: number = 0): any => {
if (depth > MAX_DEPTH) {
throw new Error('Maximum json depth exceeded');
Expand Down
12 changes: 12 additions & 0 deletions ...-charting/src/components/DeclarativeChart/__snapshots__/DeclarativeChartRTL.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4167,6 +4167,12 @@ exports[`DeclarativeChart Should render gaugechart in DeclarativeChart 1`] = `
/>
</g>
<g>
<rect
height="8"
width="8"
x="-4"
y="-4"
/>
<text
aria-hidden="true"
class=
Expand All @@ -4186,6 +4192,12 @@ exports[`DeclarativeChart Should render gaugechart in DeclarativeChart 1`] = `
420
</text>
</g>
<rect
height="8"
width="8"
x="-4"
y="-4"
/>
<text
class=

Expand Down
Loading