-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump api-extractor to latest #33692
Open
mainframev
wants to merge
9
commits into
microsoft:master
Choose a base branch
from
mainframev:bump-api-extactor-bc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
fabricteam
reviewed
Jan 20, 2025
fabricteam
reviewed
Jan 20, 2025
🕵 FluentUIV0 No visual regressions between this PR and main |
Pull request demo site: URL |
Hotell
reviewed
Jan 21, 2025
Hotell
reviewed
Jan 21, 2025
Hotell
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes needed, ty
Hotell
approved these changes
Jan 21, 2025
mainframev
force-pushed
the
bump-api-extactor-bc
branch
from
January 24, 2025 21:23
950c6dd
to
cdb89db
Compare
mainframev
force-pushed
the
bump-api-extactor-bc
branch
from
January 28, 2025 10:35
cdb89db
to
34cd3ef
Compare
@microsoft/charting-team @microsoft/fui-wc Hello folks, gentle ping, please could you review? 🙏🏻 |
AtishayMsft
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Previous versions of api-extractor did not enforce
reportFileName
file extension."reportFileName":"api-report.md"
-> api-report.mdNew Behavior
Now it's automatically appends
api.md
to report file. In our codebase it's causing breaking changes to some report files."reportFileName": "api-report.md"
-> api-report.md.api.md"reportFileName": "<unscopedPackageName>.unstable.api.md"
-> .unstable.api.md.api.mdRelated Issue(s)