-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add dry-run mode to production Azure Pipelines #33608
base: master
Are you sure you want to change the base?
Conversation
📊 Bundle size report✅ No changes found |
Pull request demo site: URL |
3c9509e
to
7f2a37a
Compare
@@ -78,10 +73,10 @@ extends: | |||
displayName: 'Create tarball' | |||
workingDirectory: 'packages/react' | |||
|
|||
- ${{ if ne(parameters.isTestRun, true) }}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use new dryRun
parameter for consistency
@@ -59,11 +57,6 @@ extends: | |||
steps: | |||
- template: .devops/templates/tools.yml@self | |||
|
|||
- script: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to tools.yml
|
||
steps: | ||
- template: .devops/templates/tools.yml@self | ||
|
||
- script: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to tools.yml
azure-pipelines.release.yml
Outdated
@@ -128,7 +124,7 @@ extends: | |||
- script: | | |||
yarn publish:beachball -n $(npmToken) --config scripts/beachball/src/release-v8.config.js --message 'release: applying package updates - react v8' | |||
git reset --hard origin/master | |||
condition: eq(variables.skipPublish, false) | |||
condition: eq(parameters.dryRun, false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used dryRun
for consistency
7f2a37a
to
ab8563a
Compare
Previous Behavior
Not all production Azure Pipelines supported dryRun mode, meaning they couldn't run without side effects like publishing artifacts to registries.
New Behavior
This PR adds a
dryRun
parameter to several Azure Pipelines YAML files. Now, you can test the pipeline without making actual changes—super handy for updating the Component Governance report that's only generated in production. The main changes include adding thedryRun
parameter, updating conditions to check this parameter, and tweaking or removing existing dry run-related code.