chore(react-provider): Updating FluentProvider types to avoid implicit import in API definition

[khmakoto]

Previous Behavior

Because of type expansion due to inference of the FluentProvider, the API definition for @fluentui/react-provider included an implicit import of @fluentui/tokens.

New Behavior

By adding an explicit type of ForwardRefComponent<FluentProviderProps> to FluentProvider, we remove the implicit reference to @fluentui/tokens in the API file.

Related Issue(s)

• Fixes [Bug]: index.d.ts for @fluentui/react-provider references a non-dependency #33189

[github-actions]

📊 Bundle size report

✅ No changes found

[github-actions]

Pull request demo site: URL

[khmakoto]

We should wait until #33599 is merged so that API related failures in other packages go away.

[Hotell]

I checked the referenced issue but it seems like there is some confusion which might actually be on the user side regarding pnpm setup etc.

• they mention swc -> swc has nothing to do with types we produce
• they mention "missing dependency" -> that's strange as the dependency chain goes react-provider->react-theme->tokens meaning all the .d.ts necessary are in place and work as expected

regarding the explicit types:

• using as assertion is an antipattern that should be avoided ( we can turn lint rule for that )
• I guess it has finally good opportunity to enforce explicit type declarations (https://typescript-eslint.io/rules/explicit-module-boundary-types and https://typescript-eslint.io/rules/explicit-function-return-type, discussed [Feature]: create eslint rule to enforce style hook API consistency #30385 (comment))
  • faster TSC execution
  • no unwrapped (verbose) types in produced .d.ts by accident