[react-nav-preview](feat): Allowing Nav to be navigable by tabbing #33232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report✅ No changes found |
packages/react-components/react-nav-preview/library/src/components/NavDrawer/useNavDrawer.ts
Show resolved
Hide resolved
|
Pull request demo site: URL |
packages/react-components/react-nav-preview/library/src/components/NavDrawer/useNavDrawer.ts
Outdated
Show resolved
Hide resolved
Mitch-At-Work
requested changes
Nov 7, 2024
Mitch-At-Work
approved these changes
Nov 7, 2024
mltejera
changed the title
smhigley
reviewed
Nov 8, 2024
packages/react-components/react-nav-preview/library/etc/react-nav-preview.api.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to the
NavDrawercomponent by exposing atabbableprop, allowing consumers to enable both tab and arrow navigation. Additionally, it includes some import adjustments to accommodate this new feature.New Feature:
tabbableprop toNavDrawerto enable both tab and arrow navigation. (packages/react-components/react-nav-preview/library/src/components/NavDrawer/NavDrawer.types.ts)useNavDrawer_unstablehook to utilize thetabbableprop for navigation. (packages/react-components/react-nav-preview/library/src/components/NavDrawer/useNavDrawer.ts)Controlledstory to demonstrate the use of thetabbableprop. (packages/react-components/react-nav-preview/stories/src/NavDrawer/Controlled.stories.tsx)Import Adjustments:
TabsterDOMAttributeimport to support the newtabbableprop. (packages/react-components/react-nav-preview/library/etc/react-nav-preview.api.md)NavDrawerPropstype to includetabsterDomAttribute. (packages/react-components/react-nav-preview/library/etc/react-nav-preview.api.md)