Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace-plugin): properly resolve isCi on ADO #33165

Merged

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Oct 29, 2024

Previous Behavior

New Behavior

on ADO process.env.TF_BUILD was never true rather True 🫡.

This PR fixes this inconsistency that was affecting generate-api executor functionality on CI environment.

Related Issue(s)

@Hotell Hotell marked this pull request as ready for review October 29, 2024 11:10
@Hotell Hotell requested a review from a team as a code owner October 29, 2024 11:10
@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@Hotell Hotell merged commit 2953c5d into microsoft:master Oct 29, 2024
18 checks passed
@Hotell Hotell deleted the workspace/fix-invalid-isCi-resolution branch October 29, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants