-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new feature for Size and Shape for Skeleton. #32455
base: master
Are you sure you want to change the base?
Add new feature for Size and Shape for Skeleton. #32455
Conversation
@shethaadit please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
/** | ||
* Sizes for the Skeleton | ||
*/ | ||
export type SkeletonSize = 8 | 12 | 16 | 20 | 24 | 28 | 32 | 36 | 40 | 48 | 56 | 64 | 72 | 96 | 120 | 128; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be good to import existing SkeletonItemSize
or to import this type in SkeletonItem.types.ts
. Currently it duplicates SkeletonItemSize
import type { SkeletonSlots, SkeletonState } from './Skeleton.types'; | ||
import type { SlotClassNames } from '@fluentui/react-utilities'; | ||
import { tokens } from '@fluentui/react-theme'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to change styles? This feature requires only to pass size
and shape
props. You'll need to add context for this
This is the PR which add an amazing feature to support
size
andshape
props to Skeleton. Here is the linked work item - #31664 (comment)Previous Behavior
New Behavior