Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace-plugin): scaffold executors boilerplate (build,generate-api,type-check,verify-packaging,clean) #32299

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Aug 14, 2024

Previous Behavior

New Behavior

we will need only 5 executors to start with in order to remove just-scripts in v9 packages. This PR generates boilerplate for those.

what about lint, e2e etc ?

for lint we will migrate to direct eslint CLI invocation as we do for jest, e2e will be kept as is ( invoking binary directly )

  • boilerplate generated via:
    yarn nx g @nx/plugin:executor --name <executor-name> --project workspace-plugin --nameAndDirectoryFormat derived

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2024

📊 Bundle size report

✅ No changes found

@Hotell Hotell changed the title feat(workspace-plugin): scaffold exeutors boilerplate (build,generate-api,type-check,verify-packaging) feat(workspace-plugin): scaffold exeutors boilerplate (build,generate-api,type-check,verify-packaging,clean) Aug 14, 2024
@Hotell Hotell mentioned this pull request Aug 14, 2024
39 tasks
@Hotell Hotell changed the title feat(workspace-plugin): scaffold exeutors boilerplate (build,generate-api,type-check,verify-packaging,clean) feat(workspace-plugin): scaffold executors boilerplate (build,generate-api,type-check,verify-packaging,clean) Aug 14, 2024
@Hotell
Copy link
Contributor Author

Hotell commented Aug 14, 2024

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@Hotell Hotell marked this pull request as ready for review August 14, 2024 14:43
@Hotell Hotell requested a review from a team as a code owner August 14, 2024 14:43
@Hotell Hotell requested a review from dmytrokirpa August 15, 2024 12:05
@Hotell Hotell merged commit 4d9fd75 into microsoft:master Aug 23, 2024
20 checks passed
@Hotell Hotell deleted the nx/replace-just-with-nx/v1 branch August 23, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants