Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: split v9 migration packages to follow our /library /story structure #32173

Merged
merged 2 commits into from
Jul 31, 2024
Merged

chore: split v9 migration packages to follow our /library /story structure #32173

merged 2 commits into from
Jul 31, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 31, 2024 •
edited
Loading

Previous Behavior

migration packages fail on type-check target https://uifabric.visualstudio.com/fabricpublic/_build/results?buildId=354791&view=logs&j=258ec178-2d8b-5611-7b9b-60c5c95dae55&t=254ee48e-1503-524f-f75e-e2c69d0380f5&l=3532

New Behavior

type-check failures are expected as we switched target dependency of type-check from "dependsOn": ["build","^build"] to "dependsOn": ["^build"], which dissallowes using "self imports" (which are all over stories).

We also forgot to migrate these 2 migration packages to follow our new v9 project/domain structure. this PR fixes it

Note

Based on RFC v9 react packages are split in two: #30514

Package/Scaffold changes:
package split changes within react-components. before and after.

  • this PR applies the migration for cxe-red owned packages
    • fully automated via yarn nx g @fluentui/workspace-plugin:split-library-in-two --project @fluentui/react-<name>
  • api.md files needed to be re-generated ( only formatting changes - caused by inconsistent api-extractor parser )

Related Issue(s)

@github-actions github-actions bot added this to the July Project Cycle Q3 2024 milestone Jul 31, 2024
@Hotell Hotell changed the title Nx/fix projects after migration chore: split v9 migration packages to follow our /library /story structure Jul 31, 2024
@fabricteam
Copy link
Collaborator

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 35 43 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 676 651 5000
Button mount 309 305 5000
Field mount 1172 1158 5000
FluentProvider mount 732 728 5000
FluentProviderWithTheme mount 88 83 10
FluentProviderWithTheme virtual-rerender 35 43 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 81 72 10
MakeStyles mount 883 874 50000
Persona mount 1798 1735 5000
SpinButton mount 1413 1422 5000
SwatchPicker mount 1686 1671 5000

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonMinimalPerf.default 89 88 1.01:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 102 79 1.29:1
FlexMinimalPerf.default 168 142 1.18:1
IconMinimalPerf.default 426 373 1.14:1
VideoMinimalPerf.default 468 426 1.1:1
AvatarMinimalPerf.default 114 105 1.09:1
ListWith60ListItems.default 382 352 1.09:1
DividerMinimalPerf.default 223 206 1.08:1
GridMinimalPerf.default 205 189 1.08:1
ButtonSlotsPerf.default 316 295 1.07:1
RadioGroupMinimalPerf.default 272 254 1.07:1
ListMinimalPerf.default 320 305 1.05:1
ImageMinimalPerf.default 237 227 1.04:1
LabelMinimalPerf.default 235 227 1.04:1
SkeletonMinimalPerf.default 210 202 1.04:1
StatusMinimalPerf.default 399 384 1.04:1
TextMinimalPerf.default 206 199 1.04:1
AttachmentSlotsPerf.default 640 622 1.03:1
CarouselMinimalPerf.default 269 261 1.03:1
ItemLayoutMinimalPerf.default 714 690 1.03:1
ProviderMinimalPerf.default 207 201 1.03:1
RefMinimalPerf.default 115 112 1.03:1
SliderMinimalPerf.default 770 748 1.03:1
DatepickerMinimalPerf.default 3587 3502 1.02:1
DialogMinimalPerf.default 456 449 1.02:1
DropdownManyItemsPerf.default 392 385 1.02:1
DropdownMinimalPerf.default 1447 1424 1.02:1
EmbedMinimalPerf.default 1917 1881 1.02:1
MenuMinimalPerf.default 507 496 1.02:1
PopupMinimalPerf.default 357 350 1.02:1
TableMinimalPerf.default 251 246 1.02:1
TextAreaMinimalPerf.default 295 288 1.02:1
ToolbarMinimalPerf.default 555 546 1.02:1
ChatWithPopoverPerf.default 191 189 1.01:1
CheckboxMinimalPerf.default 1147 1138 1.01:1
InputMinimalPerf.default 562 557 1.01:1
ProviderMergeThemesPerf.default 653 648 1.01:1
SegmentMinimalPerf.default 193 191 1.01:1
TableManyItemsPerf.default 1129 1114 1.01:1
CustomToolbarPrototype.default 1507 1491 1.01:1
AccordionMinimalPerf.default 82 82 1:1
ChatDuplicateMessagesPerf.default 161 161 1:1
ChatMinimalPerf.default 445 444 1:1
HeaderMinimalPerf.default 204 204 1:1
ListNestedPerf.default 334 335 1:1
MenuButtonMinimalPerf.default 968 969 1:1
TooltipMinimalPerf.default 1291 1286 1:1
AnimationMinimalPerf.default 307 309 0.99:1
ButtonOverridesMissPerf.default 654 662 0.99:1
CardMinimalPerf.default 311 313 0.99:1
LayoutMinimalPerf.default 198 200 0.99:1
ReactionMinimalPerf.default 210 212 0.99:1
SplitButtonMinimalPerf.default 2282 2311 0.99:1
TreeWith60ListItems.default 87 88 0.99:1
AlertMinimalPerf.default 158 162 0.98:1
HeaderSlotsPerf.default 456 465 0.98:1
ListCommonPerf.default 398 407 0.98:1
RosterPerf.default 1555 1591 0.98:1
PortalMinimalPerf.default 82 84 0.98:1
TreeMinimalPerf.default 476 486 0.98:1
FormMinimalPerf.default 222 229 0.97:1
LoaderMinimalPerf.default 190 197 0.96:1
BoxMinimalPerf.default 183 192 0.95:1

@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 631 631 5000
Breadcrumb mount 1691 1698 1000
Checkbox mount 1698 1726 5000
CheckboxBase mount 1510 1479 5000
ChoiceGroup mount 2980 3001 5000
ComboBox mount 690 684 1000
CommandBar mount 6598 6632 1000
ContextualMenu mount 13117 13006 1000
DefaultButton mount 778 807 5000
DetailsRow mount 2251 2266 5000
DetailsRowFast mount 2236 2265 5000
DetailsRowNoStyles mount 2114 2044 5000
Dialog mount 2861 2679 1000
DocumentCardTitle mount 235 231 1000
Dropdown mount 1981 2009 5000
FocusTrapZone mount 1164 1170 5000
FocusZone mount 1105 1098 5000
GroupedList mount 42449 42737 2
GroupedList virtual-rerender 20245 20475 2
GroupedList virtual-rerender-with-unmount 52204 52070 2
GroupedListV2 mount 225 228 2
GroupedListV2 virtual-rerender 212 216 2
GroupedListV2 virtual-rerender-with-unmount 232 224 2
IconButton mount 1127 1116 5000
Label mount 340 347 5000
Layer mount 2734 2817 5000
Link mount 401 406 5000
MenuButton mount 990 1000 5000
MessageBar mount 21272 21330 5000
Nav mount 2017 2034 1000
OverflowSet mount 786 766 5000
Panel mount 1910 1847 1000
Persona mount 769 746 1000
Pivot mount 888 925 1000
PrimaryButton mount 933 907 5000
Rating mount 4719 4746 5000
SearchBox mount 920 924 5000
Shimmer mount 1895 1917 5000
Slider mount 1361 1350 5000
SpinButton mount 3006 2963 5000
Spinner mount 410 405 5000
SplitButton mount 1858 1877 5000
Stack mount 419 427 5000
StackWithIntrinsicChildren mount 872 879 5000
StackWithTextChildren mount 2784 2764 5000
SwatchColorPicker mount 6480 6460 5000
TagPicker mount 1492 1463 5000
Text mount 396 393 5000
TextField mount 961 959 5000
ThemeProvider mount 864 844 5000
ThemeProvider virtual-rerender 601 587 5000
ThemeProvider virtual-rerender-with-unmount 1325 1279 5000
Toggle mount 635 602 5000
buttonNative mount 191 183 5000

@bsunderhus bsunderhus mentioned this pull request Jul 31, 2024
Merged
@Hotell Hotell marked this pull request as ready for review July 31, 2024 16:52
@Hotell Hotell merged commit 496e9e6 into microsoft:master Jul 31, 2024
21 checks passed
@Hotell Hotell deleted the nx/fix-projects-after-migration branch July 31, 2024 17:06
@Hotell Hotell mentioned this pull request Aug 1, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@sopranopillow sopranopillow sopranopillow approved these changes

@ling1726 ling1726 ling1726 approved these changes

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT GeoffCoxMSFT is a code owner

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
July Project Cycle Q3 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@Hotell @fabricteam @sopranopillow @ling1726